Looping hardware envelopes (EE1) on noise channel are not applied during playback

[TakuikaNinja]

Version

• Dn-FamiTracker version:
  • 0.5.2
• OS:
  • EndeavourOS, via Wine 11.1

Description

Looping hardware envelopes (EE1) on the noise channel sets the correct register bits but does not loop the envelope during playback.

The tooltip for the EEx effect is also misleading compared to the effects table. It should be describing the hardware envelope behaviour in addition to the length counter.

Steps to reproduce

1. Open a new module.
2. Enter any noise pitch, a volume value, and the EE1 effect. The noise hardware envelope does not loop.
3. Copy the data to a pulse channel. The pulse hardware envelope loops as expected.
4. Export an NSF file and play it in a suitable player. The noise hardware envelope loops as expected.