From 24cb65d58581bc695fd4fea85152a1a0d1411b60 Mon Sep 17 00:00:00 2001
From: muhme <github@heikol.de>
Date: Wed, 24 Apr 2024 06:59:20 +0200
Subject: [PATCH] workaround for #60 sed inplace created permission denied

Workaround for https://github.com/Digital-Peak/DPDocker/issues/60.
Replaces eight times sed in-place editing for configuration.php by writing to the tmp file `configuration.tmp` and then moving it.
---
 webserver/scripts/install-joomla.sh | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/webserver/scripts/install-joomla.sh b/webserver/scripts/install-joomla.sh
index 270b7ed..84a1b89 100755
--- a/webserver/scripts/install-joomla.sh
+++ b/webserver/scripts/install-joomla.sh
@@ -53,15 +53,16 @@ fi
 
 # Setup configuration file
 sudo cp $(dirname $0)/configuration.php $root/configuration.php
-sed -i "s/{SITE}/$site/g" $root/configuration.php
-sed -i "s/{DBHOST}/$dbHost/g" $root/configuration.php
-sed -i "s/{DBNAME}/$dbName/g" $root/configuration.php
-sed -i "s/{SMTPHOST}/$smtpHost/g" $root/configuration.php
-sed -i "s/{PATH}/${root//\//\\/}/g" $root/configuration.php
+# prevent the use of inplace sed -i as it creates unreadable tmp file inside the Docker container on Intel macOS
+sed "s/{SITE}/$site/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
+sed "s/{DBHOST}/$dbHost/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
+sed "s/{DBNAME}/$dbName/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
+sed "s/{SMTPHOST}/$smtpHost/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
+sed "s/{PATH}/${root//\//\\/}/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
 
 # Joomla 3 needs error reporting simple because of PHP 8.2 deprecations
 if [ ! -f $root/package.json ]; then
-	sed -i "s/error_reporting = 'maximum'/error_reporting = 'simple'/g" $root/configuration.php
+	sed "s/error_reporting = 'maximum'/error_reporting = 'simple'/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
 fi
 
 # Define install folder
@@ -72,7 +73,7 @@ fi
 
 if [[ -z $dbHost || $dbHost == 'mysql'* ]]; then
 	echo "Installing Joomla with mysql"
-	sed -i "s/{DBDRIVER}/mysqli/g" $root/configuration.php
+	sed "s/{DBDRIVER}/mysqli/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
 
 	echo "Waiting for database server"
 	while ! mysqladmin ping -u root -proot -h $dbHost --silent  > /dev/null; do
@@ -104,7 +105,7 @@ fi
 
 if [[ $dbHost == 'postgres'* ]]; then
 	echo "Installing Joomla with postgres"
-	sed -i "s/{DBDRIVER}/pgsql/g" $root/configuration.php
+	sed "s/{DBDRIVER}/pgsql/g" > $root/configuration.tmp && mv $root/configuration.tmp $root/configuration.php
 	export PGPASSWORD=root
 
 	# Clear existing connections