Skip to content

Commit e7fe3d3

Browse files
authored
Bump database schema version (#225)
* Bump database schema version * Drop old Python versions * Update DB tarfile artifact reference * Update Python version requirements in README * Pin sqlacodegen version to 3.0.0rc5 * Update sqlacodegen command
1 parent 42f5a57 commit e7fe3d3

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
15+
python-version: [ "3.10", "3.11", "3.12", "3.13" ]
1616
sqlalchemy-version: ["sqlalchemy==1.4", "sqlalchemy>=2,<3"]
1717
services:
1818
mariadb:

.github/workflows/test-and-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
[push, pull_request]
55

66
env:
7-
DATABASE_SCHEMA: 4.2.1
7+
DATABASE_SCHEMA: 4.4.0
88

99
permissions:
1010
contents: read

.github/workflows/update-orm.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ jobs:
5959
if: ${{ steps.checkUpdate.outputs.needsUpdate == 'true' }}
6060
uses: actions/download-artifact@v4
6161
with:
62-
name: package-distributions
63-
path: dist/
62+
name: database
63+
path: database/
6464

6565
- uses: shogo82148/actions-setup-mysql@v1
6666
if: ${{ steps.checkUpdate.outputs.needsUpdate == 'true' }}
@@ -82,7 +82,7 @@ jobs:
8282
database = ispybtest
8383
EOF
8484
85-
tar xfz "dist/ispyb-database.tar.gz"
85+
tar xfz "database/ispyb-database.tar.gz"
8686
patch -p1 < "src/ispyb/sqlalchemy/sqlacodegen.patch"
8787
8888
printf 'Waiting for MySQL database to accept connections'
@@ -100,7 +100,7 @@ jobs:
100100
if: ${{ steps.checkUpdate.outputs.needsUpdate == 'true' }}
101101
run: |
102102
set -eux
103-
sqlacodegen mysql+mysqlconnector://root:mariadb_root_pwd@127.0.0.1/ispyb_build --noinflect --nojoined --outfile _auto_db_schema.py.in
103+
sqlacodegen mysql+mysqlconnector://root:mariadb_root_pwd@127.0.0.1/ispyb_build --options nojoined --outfile _auto_db_schema.py.in
104104
# This code produces false positives due to non-deterministic ordering.
105105
# Add an identifier to the file, and only update/PR the changes when the
106106
# identifier indicates the file is out of date.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ as webservices.
2121
Please see https://ispyb.readthedocs.io.
2222

2323
### Requirements
24-
* Python 3.7, 3.8, 3.9, 3.10, 3.11
24+
* Python 3.7, 3.8, 3.9 (minimum), 3.10, 3.11, 3.12, 3.13 (recommended)
2525
* The MySQL Connector/Python package.
2626
* MariaDB 10.0+ or MySQL 5.6+, but we recommend MariaDB 10.2 or later.
2727
* An ISPyB database installed on the above. See the [ispyb-database](https://github.com/DiamondLightSource/ispyb-database) repository for details.

requirements_orm.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
mysql-connector-python>=8.0.32
2-
sqlacodegen<3
2+
sqlacodegen==3.0.0rc5
33
sqlalchemy>=2,<3

0 commit comments

Comments
 (0)