Attempt Windows 10 and Server 2019 compatibility

Author: mamoreau-devolutions

scripts/validate-package-manifest.ps1

@@ -0,0 +1,55 @@
+#!/usr/bin/env pwsh
+<#
+.SYNOPSIS
+    Validates that Package.appxmanifest target device family metadata stays in
+    sync with the current Windows target platform version.
+
+.PARAMETER ManifestPath
+    Path to the Package.appxmanifest file to validate.
+
+.PARAMETER ExpectedMinVersion
+    Expected MinVersion value for every TargetDeviceFamily entry.
+
+.PARAMETER ExpectedMaxVersionTested
+    Expected MaxVersionTested value for every TargetDeviceFamily entry.
+#>
+
+[CmdletBinding()]
+param(
+    [Parameter(Mandatory, Position = 0)]
+    [string] $ManifestPath,
+
+    [Parameter(Mandatory)]
+    [string] $ExpectedMinVersion,
+
+    [Parameter(Mandatory)]
+    [string] $ExpectedMaxVersionTested
+)
+
+$ErrorActionPreference = 'Stop'
+
+if (-not (Test-Path $ManifestPath -PathType Leaf)) {
+    throw "The manifest '$ManifestPath' does not exist."
+}
+
+$ManifestPath = (Resolve-Path $ManifestPath).Path
+[xml] $Manifest = Get-Content $ManifestPath
+
+$TargetDeviceFamilies = @($Manifest.Package.Dependencies.TargetDeviceFamily)
+if ($TargetDeviceFamilies.Count -eq 0) {
+    throw "No TargetDeviceFamily entries were found in '$ManifestPath'."
+}
+
+$MismatchedTargetFamilies = @()
+foreach ($TargetDeviceFamily in $TargetDeviceFamilies) {
+    if (
+        $TargetDeviceFamily.MinVersion -ne $ExpectedMinVersion -or
+        $TargetDeviceFamily.MaxVersionTested -ne $ExpectedMaxVersionTested
+    ) {
+        $MismatchedTargetFamilies += "$($TargetDeviceFamily.Name)=Min:$($TargetDeviceFamily.MinVersion)|Max:$($TargetDeviceFamily.MaxVersionTested)"
+    }
+}
+
+if ($MismatchedTargetFamilies.Count -gt 0) {
+    throw "Package.appxmanifest target family mismatch. Expected MinVersion '$ExpectedMinVersion' and MaxVersionTested '$ExpectedMaxVersionTested' for all TargetDeviceFamily entries but found: $($MismatchedTargetFamilies -join ', ')."
+}

src/Directory.Build.props

@@ -13,6 +13,7 @@
     <PropertyGroup>
         <PortableTargetFramework>net10.0</PortableTargetFramework>
         <WindowsTargetPlatformVersion>10.0.26100.0</WindowsTargetPlatformVersion>
+        <WindowsMinimumSupportedVersion>10.0.17763.0</WindowsMinimumSupportedVersion>
         <WindowsTargetFramework>$(PortableTargetFramework)-windows$(WindowsTargetPlatformVersion)</WindowsTargetFramework>
     </PropertyGroup>
 
@@ -34,7 +35,7 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="$([System.String]::Copy('$(TargetFramework)').Contains('-windows'))">
-        <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
+        <TargetPlatformMinVersion>$(WindowsMinimumSupportedVersion)</TargetPlatformMinVersion>
         <WindowsSdkPackageVersion>10.0.26100.56</WindowsSdkPackageVersion>
         <WindowsAppSDKSelfContained>true</WindowsAppSDKSelfContained>
         <RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>

src/SharedAssemblyInfo.cs

@@ -12,5 +12,5 @@
 [assembly: AssemblyFileVersion("3.3.7.0")]
 [assembly: AssemblyInformationalVersion("3.3.7")]
 #if WINDOWS
-[assembly: SupportedOSPlatform("windows10.0.19041")]
+[assembly: SupportedOSPlatform("windows10.0.17763")]
 #endif

src/UniGetUI.PAckageEngine.Interfaces/UniGetUI.PackageEngine.Interfaces.csproj

@@ -5,7 +5,7 @@
 
     <PropertyGroup>
         <SupportedOSPlatformVersion Condition="'$(TargetFramework)' == '$(WindowsTargetFramework)'"
-            >10.0.19041.0</SupportedOSPlatformVersion
+            >$(WindowsMinimumSupportedVersion)</SupportedOSPlatformVersion
         >
         <FileVersion>3.1.0.0</FileVersion>
         <InformationalVersion>3.1.0-beta0</InformationalVersion>

src/UniGetUI/Package.appxmanifest

@@ -21,8 +21,8 @@
   </Properties>
 
   <Dependencies>
-    <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
-    <TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
+    <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.17763.0" MaxVersionTested="10.0.26100.0" />
+    <TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.26100.0" />
   </Dependencies>
 
   <Resources>

src/UniGetUI/Properties/PublishProfiles/win10-x64.pubxml

@@ -6,7 +6,7 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
   <PropertyGroup>
     <PublishProtocol>FileSystem</PublishProtocol>
     <Platform>x64</Platform>
-    <RuntimeIdentifier>win10-x64</RuntimeIdentifier>
+    <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir>
     <SelfContained>true</SelfContained>
     <PublishSingleFile>False</PublishSingleFile>

src/UniGetUI/UniGetUI.csproj

@@ -56,6 +56,16 @@
         />
     </Target>
 
+    <Target
+        Name="ValidatePackageManifestTargetFamilies"
+        BeforeTargets="PrepareForBuild"
+        Condition="'$(DesignTimeBuild)' != 'true'"
+    >
+        <Exec
+            Command="pwsh -NoProfile -File ../../scripts/validate-package-manifest.ps1 -ManifestPath &quot;Package.appxmanifest&quot; -ExpectedMinVersion &quot;$(WindowsMinimumSupportedVersion)&quot; -ExpectedMaxVersionTested &quot;$(WindowsTargetPlatformVersion)&quot;"
+        />
+    </Target>
+
     <Target
         Name="EnsureBundledElevatorFromNuGet"
         BeforeTargets="PrepareForBuild"