Port old AlwaysElevate and removed AllowParallelInstallsForManager settings to use the complex settings

Author: mrixner

src/UniGetUI.PackageEngine.Operations/PackageOperations.cs

@@ -56,7 +56,7 @@ private bool RequiresAdminRights()
         {
             return Package.OverridenOptions.RunAsAdministrator is true
                     || Options.RunAsAdministrator
-                    || (Settings.Get("AlwaysElevate" + Package.Manager.Name) && Package.OverridenOptions.RunAsAdministrator != false);
+                    || (Settings.GetDictionaryItem<string, bool>("AlwaysElevate", Package.Manager.Name) && Package.OverridenOptions.RunAsAdministrator != false);
         }
 
         protected override void ApplyRetryAction(string retryMode)

src/UniGetUI/MainWindow.xaml.cs

@@ -118,7 +118,7 @@ public MainWindow()
 
             _ = AutoUpdater.UpdateCheckLoop(this, UpdatesBanner);
 
-            if (!Settings.Get("TransferredOldSettings"))
+            if (!Settings.Get("TransferredOldSettings") || !Settings.Get("TransferredOldSettings-2"))
                 TransferOldSettingsFormats();
 
             Activated += (_, e) =>
@@ -178,38 +178,53 @@ private void ClearSubtitle()
 
         private static void TransferOldSettingsFormats()
         {
-            foreach (IPackageManager Manager in PEInterface.Managers)
+            if (!Settings.Get("TransferredOldSettings"))
             {
-                string SettingName = "Disable" + Manager.Name;
-                if (Settings.Get(SettingName))
+                foreach (IPackageManager Manager in PEInterface.Managers)
                 {
-                    Settings.SetDictionaryItem("DisabledManagers", Manager.Name, true);
-                    Settings.Set(SettingName, false);
+                    string SettingName = "Disable" + Manager.Name;
+                    if (Settings.Get(SettingName))
+                    {
+                        Settings.SetDictionaryItem("DisabledManagers", Manager.Name, true);
+                        Settings.Set(SettingName, false);
+                    }
                 }
-            }
 
-            // Dependency checks don't need to be transferred, because the worst case scenario is the user has to click the "don't show again" again
+                // Dependency checks don't need to be transferred, because the worst case scenario is the user has to click the "don't show again" again
 
-            foreach (string Page in new[]{ "Discover", "Installed", "Bundles", "Updates"})
-            {
-                if (Settings.Get($"HideToggleFilters{Page}Page"))
+                foreach (string Page in new[]{ "Discover", "Installed", "Bundles", "Updates"})
                 {
-                    Settings.SetDictionaryItem("HideToggleFilters", Page, true);
-                    Settings.Set($"HideToggleFilters{Page}Page", false);
+                    if (Settings.Get($"HideToggleFilters{Page}Page"))
+                    {
+                        Settings.SetDictionaryItem("HideToggleFilters", Page, true);
+                        Settings.Set($"HideToggleFilters{Page}Page", false);
+                    }
+
+                    if (Settings.Get($"DisableInstantSearch{Page}Tab"))
+                    {
+                        Settings.SetDictionaryItem("DisableInstantSearch", Page, true);
+                        Settings.Set($"DisableInstantSearch{Page}Tab", false);
+                    }
+
+                    if (!int.TryParse(Settings.GetValue($"SidepanelWidth{Page}Page"), out int sidepanelWidth)) sidepanelWidth = 250;
+                    Settings.SetDictionaryItem("SidepanelWidths", Page, sidepanelWidth);
+                    Settings.Set($"SidepanelWidth{Page}Page", false);
                 }
 
-                if (Settings.Get($"DisableInstantSearch{Page}Tab"))
+                Settings.Set("TransferredOldSettings", true);
+            }
+
+            foreach (IPackageManager Manager in PEInterface.Managers)
+            {
+                string SettingName = "AlwaysElevate" + Manager.Name;
+                if (Settings.Get(SettingName))
                 {
-                    Settings.SetDictionaryItem("DisableInstantSearch", Page, true);
-                    Settings.Set($"DisableInstantSearch{Page}Tab", false);
+                    Settings.SetDictionaryItem("AlwaysElevate", Manager.Name, true);
+                    Settings.Set(SettingName, false);
                 }
-
-                if (!int.TryParse(Settings.GetValue($"SidepanelWidth{Page}Page"), out int sidepanelWidth)) sidepanelWidth = 250;
-                Settings.SetDictionaryItem("SidepanelWidths", Page, sidepanelWidth);
-                Settings.Set($"SidepanelWidth{Page}Page", false);
             }
 
-            Settings.Set("TransferredOldSettings", true);
+            Settings.Set("TransferredOldSettings-2", true);
         }
 
         public void HandleNotificationActivation(AppNotificationActivatedEventArgs args)

src/UniGetUI/Pages/SettingsPage.xaml.cs

@@ -493,7 +493,8 @@ void EnableOrDisableEntries()
                         CheckboxCard AdminCard = new()
                         {
                             Text = CoreTools.AutoTranslated("Always run {pm} operations with administrator rights"),
-                            SettingName = "AlwaysElevate" + Manager.Name,
+                            SettingName = Manager.Name,
+                            SettingDictionary = "AlwaysElevate"
                         };
                         AdminCard._checkbox.Content =
                             (AdminCard._checkbox.Content.ToString() ?? "").Replace("{pm}", Manager.DisplayName);
@@ -502,7 +503,8 @@ void EnableOrDisableEntries()
                         /*CheckboxCard ParallelCard = new()
                         {
                             Text = CoreTools.AutoTranslated("Allow {pm} operations to be performed in parallel"),
-                            SettingName = "AllowParallelInstallsForManager" + Manager.Name,
+                            SettingName = Manager.Name,
+                            SettingDictionary = "AllowParallelInstallsForManager"
                         };
                         ParallelCard._checkbox.Content = (ParallelCard._checkbox.Content.ToString() ?? "").Replace("{pm}", Manager.DisplayName);
                         ExtraSettingsCards[Manager].Insert(index++, ParallelCard);*/