Honor the 'remove all desktop shortcuts' setting

Author: mrixner

src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Classes/DesktopShortcutsDatabase.cs

@@ -155,20 +155,27 @@ public static List<string> GetUnknownShortcuts()
     /// <param name="PreviousShortCutList"></param>
     public static void TryRemoveNewShortcuts(IReadOnlyList<string> PreviousShortCutList)
     {
-        HashSet<string> ShortcutSet = PreviousShortCutList.ToHashSet();
-        List<string> CurrentShortcutList = DesktopShortcutsDatabase.GetShortcuts();
+        HashSet<string> ShortcutSet = [.. PreviousShortCutList];
+        List<string> CurrentShortcutList = GetShortcuts();
         foreach (string shortcut in CurrentShortcutList)
         {
             if (ShortcutSet.Contains(shortcut)) continue;
-            switch (DesktopShortcutsDatabase.GetStatus(shortcut))
+            switch (GetStatus(shortcut))
             {
                 case Status.Delete:
-                    DesktopShortcutsDatabase.DeleteFromDisk(shortcut);
+                    DeleteFromDisk(shortcut);
                     break;
                 case Status.Maintain:
                     Logger.Debug("Refraining from deleting new shortcut " + shortcut + ": user disabled its deletion");
                     break;
                 case Status.Unknown:
+                    if (Settings.Get("RemoveAllDesktopShortcuts"))
+                    {
+                        AddToDatabase(shortcut, true);
+                        DeleteFromDisk(shortcut);
+                        RemoveFromUnknownShortcuts(shortcut);
+                        break;
+                    }
                     if (UnknownShortcuts.Contains(shortcut)) continue;
                     Logger.Info("Marking the shortcut " + shortcut + " to be asked to be deleted");
                     UnknownShortcuts.Add(shortcut);

src/UniGetUI/Pages/DialogPages/DesktopShortcuts.xaml

@@ -44,7 +44,7 @@
                                     </Grid.ColumnDefinitions>
                                     <TextBlock
                                         Grid.ColumnSpan="2"
-                                        Text="Existing shortcuts on your desktop will be scanned, and you will need to pick which ones to keep and which ones to remove."
+                                        Text="Existing shortcuts on your desktop will be scanned, and you will need to pick which ones to keep and which ones to remove. If 'Delete all desktop shortcuts after an install or upgrade' is enabled, they will be deleted automatically."
                                         Margin="0,0,0,0"
                                         TextWrapping="WrapWholeWords"
                                         />

src/UniGetUI/Pages/DialogPages/DesktopShortcuts.xaml.cs

@@ -90,13 +90,13 @@ private void DeletableDesktopShortcutsList_DoubleTapped(object sender, DoubleTap
         private async void ManualScanButton_Click(object sender, RoutedEventArgs e)
         {
             DesktopShortcutsDatabase.TryRemoveNewShortcuts([]);
-            Close?.Invoke(this, EventArgs.Empty);
+            SaveChangesAndClose();
             var shortcuts = DesktopShortcutsDatabase.GetUnknownShortcuts();
             if (shortcuts.Any())
             {
                 await DialogHelper.ManageDesktopShortcuts(shortcuts);
             }
-            else
+            else if (!Settings.Get("RemoveAllDesktopShortcuts"))
             {
                 await DialogHelper.NoDesktopShortcutsFound();
             }