Fix and re-enable e2e tests

[humphd]

The e2e tests are failing in CI, and there's an odd Safari Mobile failure for me locally, see #1007 (comment).

I've disabled them for now in bda6147 but we should re-enable at some point.

[theoforger]

Could it be related to the infamous #845?

I managed to reproduce #1007 (comment) on several browsers:

# Notice how it always happen on toasts, which makes sense if the CSS is flaky
Call log:
      - Expect "toContainText" with timeout 5000ms
      - waiting for getByText('Public Certificate is Downloaded')


      68 |     await page.getByRole('button', { name: 'Download Public Certificate' }).click();
      69 |     const publicDownloadToastText = page.getByText('Public Certificate is Downloaded');
    > 70 |     await expect(publicDownloadToastText).toContainText('Public Certificate is Downloaded');
         |                                           ^
      71 |     await publicDownloadToastText.waitFor();
      72 |
      73 |     await page.getByRole('button', { name: 'Download Private Key' }).click();
        at /home/theoforger/Workbench/WebstormProjects/starchart/test/e2e/certificate-available.spec.ts:70:43

  6 failed
    [firefox] › test/e2e/certificate-available.spec.ts:66:7 › Certificate Page › Download Certificate
    [Mobile Chrome] › test/e2e/certificate-available.spec.ts:66:7 › Certificate Page › Download Certificate
    [Mobile Safari] › test/e2e/certificate-available.spec.ts:37:7 › Certificate Page › Copy Certificate
    [Mobile Safari] › test/e2e/certificate-available.spec.ts:66:7 › Certificate Page › Download Certificate
    [Microsoft Edge] › test/e2e/certificate-available.spec.ts:66:7 › Certificate Page › Download Certificate
    [Google Chrome] › test/e2e/certificate-available.spec.ts:66:7 › Certificate Page › Download Certificate
  1 flaky
    [Google Chrome] › test/e2e/certificate-available.spec.ts:37:7 › Certificate Page › Copy Certificate

And here's a recording from Playwright:

video.webm

[theoforger]

Something else is also causing CI runs to fail: This particular error is crashing the server, and it seems to be related to Prisma/database.

Sorry for the messy communication. There are many issues tangled together 🙈

[humphd]

PrismaClientKnownRequestError: 
Invalid `prisma.systemState.upsert()` invocation:


Unique constraint failed on the constraint: `SystemState_unique_key`
    at $r.handleRequestError (/home/runner/work/starchart/starchart/build/server.js:141338:17)
    at $r.handleAndLogRequestError (/home/runner/work/starchart/starchart/build/server.js:141324:16)
    at $r.request (/home/runner/work/starchart/starchart/build/server.js:141315:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async a4 (/home/runner/work/starchart/starchart/build/server.js:141702:22) {
  code: 'P2002',
  meta: {
    modelName: 'SystemState',
    driverAdapterError: DriverAdapterError: UniqueConstraintViolation
        at MariaDbTransaction.onError (/home/runner/work/starchart/starchart/build/server.js:197652:11)
        at MariaDbTransaction.performIO (/home/runner/work/starchart/starchart/build/server.js:197647:12)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        at async MariaDbTransaction.queryRaw (/home/runner/work/starchart/starchart/build/server.js:197613:20)
        at async /home/runner/work/starchart/starchart/build/server.js:139369:75
        at async mr (/home/runner/work/starchart/starchart/build/server.js:139368:14)
        at async e4.interpretNode (/home/runner/work/starchart/starchart/build/server.js:140034:24)
        at async e4.interpretNode (/home/runner/work/starchart/starchart/build/server.js:140044:51)
        at async e4.interpretNode (/home/runner/work/starchart/starchart/build/server.js:140097:40)
        at async e4.interpretNode (/home/runner/work/starchart/starchart/build/server.js:140006:35) {
      cause: {
        originalCode: '1062',
        originalMessage: "Duplicate entry 'unique' for key 'SystemState.SystemState_unique_key'",
        kind: 'UniqueConstraintViolation',
        constraint: { index: 'SystemState_unique_key' }
      }
    }
  },
  clientVersion: '7.0.1'
}

Extracting for better searchability.

[theoforger]

Not sure what's going on here, but I noticed that this commit removed db:seed from the test setup script without much explanation.

If I add it back, the E2E test can pass, but I get a failure in unit test instead:

  FAIL  test/unit/system-state.server.test.ts > initialize() > can create system state
AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ test/unit/system-state.server.test.ts:22:40
     20|     expect(typeof state).toEqual('object');
     21|     expect(state.unique).toBe(`unique`);
     22|     expect(state.reconciliationNeeded).toBe(true);
       |                                        ^
     23|   });
     24| 

[humphd]

The new Prisma stuff wants the seed to happen in the config, but I might be doing it wrong? I didn't dig too deeply into it. Needs research.