Gradle 9/Configuration Cache support

[TheDGOfficial]

I think it would help build times. I can try later and send what it's complaining or erroring about, but likely just need to fix deprecation warnings in Gradle 8 to make it work in Gradle 9. For configuration cache I guess it would take more effort to support it.

[Deftu]

I'm pretty sure it requires Loom to be bumped and several things in DGT's codebase to be changed.

[Deftu]

And Preprocessor does not support configuration cache, to my knowledge.

[Wyvest]

And Preprocessor does not support configuration cache, to my knowledge.

It does ReplayMod/preprocessor@7930743

[TheDGOfficial]

And Preprocessor does not support configuration cache, to my knowledge.

It does ReplayMod/preprocessor@7930743

That's great news. I'll keep the issue open for now, but do let me know if some other component does not support or the issue should go to that component's github repository. Configuration Cache is the preferred mode of execution in Gradle 9 and the default for new projects (not existing projects yet though), so it makes sense to support it going forward.

[TheDGOfficial]

It seems like preprecessor is at fault for Gradle 9 not working so max version is 8.14.3 (w/ java 21 lts or 24 at maximum, as java 25 lts is only supported from gradle 8 onwards), although the initial errors after enabling configuration cache in Gradle 8 seems to be related to bloom:

12 problems were found storing the configuration cache, 6 of which seem unique.
- Plugin 'dev.deftu.gradle.tools': external process started 'git config --get remote.origin.url'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Plugin 'dev.deftu.gradle.tools': external process started 'git rev-parse --abbrev-ref HEAD'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Plugin 'dev.deftu.gradle.tools': external process started 'git rev-parse HEAD'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Task `:1.21.10-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: cannot serialize object of type 'org.gradle.api.internal.file.DefaultSourceDirectorySet', a subtype of 'org.gradle.api.file.SourceDirectorySet', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:1.21.5-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: cannot serialize object of type 'org.gradle.api.internal.file.DefaultSourceDirectorySet', a subtype of 'org.gradle.api.file.SourceDirectorySet', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:1.21.7-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: cannot serialize object of type 'org.gradle.api.internal.file.DefaultSourceDirectorySet', a subtype of 'org.gradle.api.file.SourceDirectorySet', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types

* What went wrong:
Error while saving task graph
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `replacement` of `dev.deftu.gradle.bloom.BloomExtension$ReplacementInfo` bean found in field `replacements` of task `:1.21.5-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `replacement` of `dev.deftu.gradle.bloom.BloomExtension$ReplacementInfo` bean found in field `replacements` of task `:1.21.7-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `replacement` of `dev.deftu.gradle.bloom.BloomExtension$ReplacementInfo` bean found in field `replacements` of task `:1.21.10-fabric:bloomReplaceJava` of type `dev.deftu.gradle.bloom.SourceReplacementTask`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca

After removing bloom from the plugins block of the build file (for testing), the build still fails, this time no bloom but still incompatible with configuration cache:

12 problems were found storing the configuration cache, 6 of which seem unique.
- Plugin 'dev.deftu.gradle.tools': external process started 'git config --get remote.origin.url'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Plugin 'dev.deftu.gradle.tools': external process started 'git rev-parse --abbrev-ref HEAD'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Plugin 'dev.deftu.gradle.tools': external process started 'git rev-parse HEAD'
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Task `:1.21.10-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:1.21.5-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:1.21.7-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.14.3/userguide/configuration_cache.html#config_cache:requirements:disallowed_types

* What went wrong:
Error while saving task graph
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `version` of `dev.deftu.gradle.utils.MCData` bean found in field `$mcData` of `dev.deftu.gradle.tools.Resources_gradle$2$1$2` bean found in field `toApply` of `org.gradle.api.internal.file.copy.MatchingCopyAction` bean found in field `mainSpec` of task `:1.21.5-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `version` of `dev.deftu.gradle.utils.MCData` bean found in field `$mcData` of `dev.deftu.gradle.tools.Resources_gradle$2$1$2` bean found in field `toApply` of `org.gradle.api.internal.file.copy.MatchingCopyAction` bean found in field `mainSpec` of task `:1.21.7-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca
> Configuration cache state could not be cached: field `value` of `kotlin.InitializedLazyImpl` bean found in field `releaseTime$delegate` of `dev.deftu.gradle.utils.version.MinecraftReleaseVersion` bean found in field `version` of `dev.deftu.gradle.utils.MCData` bean found in field `$mcData` of `dev.deftu.gradle.tools.Resources_gradle$2$1$2` bean found in field `toApply` of `org.gradle.api.internal.file.copy.MatchingCopyAction` bean found in field `mainSpec` of task `:1.21.10-fabric:processResources` of type `org.gradle.language.jvm.tasks.ProcessResources`: error writing value of type 'java.time.OffsetDateTime'
   > Unable to make private java.lang.Object java.time.OffsetDateTime.writeReplace() accessible: module java.base does not "opens java.time" to unnamed module @5cdb5fca

After solving those the preprecessor incompatibilities would likely show up as the new errors, as I assume the commit of preprecessor adding support is not yet in a released version.