Skip to content

Commit d2d4360

Browse files
fix: change formality tests to look for text containing "dir" or "Ihnen" for German formality, rather than depending on exact translation
1 parent d086626 commit d2d4360

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

tests/translateDocument.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,19 +141,19 @@ describe('translate document', () => {
141141
await translator.translateDocument(exampleDocument, outputDocumentPath, null, 'de', {
142142
formality: 'more',
143143
});
144-
expect(fs.readFileSync(outputDocumentPath).toString()).toBe('Wie geht es Ihnen?');
144+
expect(fs.readFileSync(outputDocumentPath).toString()).toContain('Ihnen');
145145
await unlinkP(outputDocumentPath);
146146

147147
await translator.translateDocument(exampleDocument, outputDocumentPath, null, 'de', {
148148
formality: 'default',
149149
});
150-
expect(fs.readFileSync(outputDocumentPath).toString()).toBe('Wie geht es Ihnen?');
150+
expect(fs.readFileSync(outputDocumentPath).toString()).toContain('Ihnen');
151151
await unlinkP(outputDocumentPath);
152152

153153
await translator.translateDocument(exampleDocument, outputDocumentPath, null, 'de', {
154154
formality: 'less',
155155
});
156-
expect(fs.readFileSync(outputDocumentPath).toString()).toBe('Wie geht es dir?');
156+
expect(fs.readFileSync(outputDocumentPath).toString()).toContain('dir');
157157
},
158158
testTimeout,
159159
);

tests/translateText.test.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -118,45 +118,45 @@ describe('translate text', () => {
118118
async () => {
119119
const translator = makeTranslator();
120120
const input = 'How are you?';
121-
const formal = 'Wie geht es Ihnen?';
122-
const informal = 'Wie geht es dir?';
123-
expect((await translator.translateText(input, null, 'de')).text).toBe(formal);
121+
const formal = 'Ihnen'; // Wie geht es Ihnen?
122+
const informal = 'dir'; // Wie geht es dir?
123+
expect((await translator.translateText(input, null, 'de')).text).toContain(formal);
124124
expect(
125125
(await translator.translateText(input, null, 'de', { formality: 'less' })).text,
126-
).toBe(informal);
126+
).toContain(informal);
127127
expect(
128128
(await translator.translateText(input, null, 'de', { formality: 'default' })).text,
129-
).toBe(formal);
129+
).toContain(formal);
130130
expect(
131131
(await translator.translateText(input, null, 'de', { formality: 'more' })).text,
132-
).toBe(formal);
132+
).toContain(formal);
133133

134134
const formalityLess = <deepl.Formality>'LESS'; // Type cast to silence type-checks
135135
expect(
136136
(await translator.translateText(input, null, 'de', { formality: formalityLess }))
137137
.text,
138-
).toBe(informal);
138+
).toContain(informal);
139139

140140
const formalityDefault = <deepl.Formality>'DEFAULT'; // Type cast to silence type-checks
141141
expect(
142142
(await translator.translateText(input, null, 'de', { formality: formalityDefault }))
143143
.text,
144-
).toBe(formal);
144+
).toContain(formal);
145145

146146
const formalityMore = <deepl.Formality>'MORE'; // Type cast to silence type-checks
147147
expect(
148148
(await translator.translateText(input, null, 'de', { formality: formalityMore }))
149149
.text,
150-
).toBe(formal);
150+
).toContain(formal);
151151

152152
expect(
153153
(await translator.translateText(input, null, 'de', { formality: 'prefer_less' }))
154154
.text,
155-
).toBe(informal);
155+
).toContain(informal);
156156
expect(
157157
(await translator.translateText(input, null, 'de', { formality: 'prefer_more' }))
158158
.text,
159-
).toBe(formal);
159+
).toContain(formal);
160160

161161
// Using prefer_* with a language that does not support formality is not an error
162162
await translator.translateText(input, null, 'tr', { formality: 'prefer_more' });

0 commit comments

Comments
 (0)