Skip to content

Commit d3cc58e

Browse files
committed
Version 1.2.1
Fix warning when running maintenance scripts
1 parent 633e1b2 commit d3cc58e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ExternalRedirect.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
'author' => 'Davis Mosenkovs',
2828
'url' => 'https://www.mediawiki.org/wiki/Extension:ExternalRedirect',
2929
'description' => 'Allows to make redirects to external websites',
30-
'version' => '1.2.0',
30+
'version' => '1.2.1',
3131
);
3232

3333
$wgExtensionMessagesFiles['ExternalRedirect'] = dirname( __FILE__ ) . '/ExternalRedirect.i18n.php';
@@ -54,15 +54,17 @@ function wfExternalRedirectParserInit( Parser $parser ) {
5454
}
5555

5656
function wfExternalRedirectRender($parser, $url = '') {
57-
global $wgExternalRedirectNsIDs, $wgExternalRedirectPages, $wgExternalRedirectURLRegex, $wgExternalRedirectDeniedShowURL;
57+
global $wgCommandLineMode, $wgExternalRedirectNsIDs, $wgExternalRedirectPages, $wgExternalRedirectURLRegex, $wgExternalRedirectDeniedShowURL;
5858
$parser->getOutput()->updateCacheExpiry(0);
5959
if(!wfParseUrl($url) || strpos($url, chr(13))!==false || strpos($url, chr(10))!==false || strpos($url, chr(0))!==false) {
6060
return wfMessage('externalredirect-invalidurl')->text();
6161
}
6262
if((in_array($parser->getTitle()->getNamespace(), $wgExternalRedirectNsIDs, true)
6363
|| in_array($parser->getTitle()->getPrefixedText(), $wgExternalRedirectPages, true))
6464
&& ($wgExternalRedirectURLRegex==='' || preg_match($wgExternalRedirectURLRegex, $url)===1)) {
65-
header('Location: '.$url);
65+
if($wgCommandLineMode!==true) {
66+
header('Location: '.$url);
67+
}
6668
return wfMessage('externalredirect-text', $url)->text();
6769
} else {
6870
return wfMessage('externalredirect-denied')->text().($wgExternalRedirectDeniedShowURL

0 commit comments

Comments
 (0)