coverage(cli): Remove static analysis and improve coverage pipeline

Author: Davidyz

.github/workflows/test_and_cov.yml

@@ -56,9 +56,6 @@ jobs:
           pdm run coverage report -m
           pdm run coverage xml -i
 
-      - name: static analysis by basedpyright
-        run: pdm run basedpyright
-
       - name: upload coverage reports to codecov
         uses: codecov/codecov-action@v5
         with:

scripts/coverage.sh

@@ -0,0 +1,14 @@
+#!/bin/sh
+
+export EXTRA_COVERAGEPY_ARGS='--append'
+
+make deps
+
+pdm run coverage erase
+
+# chroma 0.6.3
+EXTRA_LOCK_ARGS="--group chroma0" make coverage
+# default install (chroma 1.x)
+make coverage
+
+pdm run coverage report -m

src/vectorcode/database/chroma.py

@@ -32,7 +32,7 @@
 )
 from vectorcode.database.utils import get_collection_id, get_uuid, hash_file
 
-if not chromadb.__version__.startswith("1."):
+if not chromadb.__version__.startswith("1."):  # pragma: nocover
     logging.error(
         f"""
 Found ChromaDB {chromadb.__version__}, which is incompatible wiht your VectorCode installation. Please install `vectorcode`.
@@ -146,10 +146,13 @@ async def maybe_lock(self):
         """
         Acquire a file (dir) lock if using persistent client.
         """
+        locked = False
         if self._lock is not None:
             await self._lock.acquire()
+            locked = True
         yield
-        if self._lock is not None:
+        if locked:
+            assert self._lock is not None
             await self._lock.release()
 
     async def _create_or_get_collection(