Skip to content

Comments on progress report 2 #1

@djvill

Description

@djvill

You've fought your way through a lot of data-wrangling! Bravo for being persistent and getting through it all.

In the progress report, you refer to sentences (1) and (2), which aren't in the text. Otherwise, this is a very put-together document!

I'd recommend trying to be more consistent in using dplyr functions for things like renaming dataframe columns, creating new columns, etc. In my experience, it's way way easier to comprehend and debug data-wrangling code that's written with dplyr

You might want to use more descriptive object names; future-you might not remember what the difference between CQ1 and CQ_new1 was supposed to be! In general, if you find yourself struggling to come up with good names for an object, that might be a signal that it doesn't need to be its own object; you could probably pare down the number of dataframes you create

It appears that there are some missing plots in both the SPR and AJT documents. Check to see if your local repo has a Data_Analysis/SPR/SPR_Analysis_files directory with figures in it; if so, make sure to commit and push this directory so readers can see your plots! Likewise, there should be a similar directory within L1_L2_Data/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions