Checking Intel regions should be skipped based on model config (e.g. for AMD boards) #137
Description
Currently, workaround using the dry run (-x) flag is necessary to flash AMD boards:
osfv_cli rte --rte_ip 192.168.10.176 flash write --rom pcengines_apu6_v0.9.0.rom -x
DUT model retrieved from snipeit: APU6
Using rte command is invasive action, checking first if the device is not used...
Asset 38 is already checked out by you
Verifying flash image completeness of pcengines_apu6_v0.9.0.rom ...
Invalid image, no FLVALSIG found!
Failed to load image file. Cannot verify the presence of Intel regions.
Writing pcengines_apu6_v0.9.0.rom to flash...
Executing command: flashrom -p linux_spi:dev=/dev/spidev1.0,spispeed=16000 -c W25Q64JV-.Q -w /data/write.rom
flashrom v1.3.0 on Linux 5.4.69 (armv7l)
flashrom is free software, get the source code at https://flashrom.org
Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
Found Winbond flash chip "W25Q64JV-.Q" (8192 kB, SPI) on linux_spi.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
Thanks for your help!
Reading old flash chip contents... done.
Erasing and writing flash chip...
Warning: Chip content is identical to the requested image.
Erase/write done.
Flash written successfully
Since the asset 38 has been checkout manually by you prior running this script, it will NOT be checked in automatically. Please return the device when work is finished.
This is cause by the recent introduction of binary parsing, which was perhaps not thought through fully.