DTS fails to update MSI Pro Z790-P when using Firmware Update Mode

[laurelmay]

Component

Dasharo Tools Suite

Device

MSI Pro Z790-P

Dasharo version

v0.9.3

Dasharo Tools Suite version

v2.7.2

Test case ID

No response

Brief summary

When trying to perform a firmware update from v0.9.3 to v0.9.4 on an MSI Z790-P Wi-Fi DDR4, DTS reports that the update was applied successfully; however, it in fact failed with a line reporting:

cat: invalid argument

How reproducible

100%

How to reproduce

1. Boot using Firmware Update Mode
2. Press 9 to get into regular DTS menu
3. Enter credentials for DPP
4. Press 2 to perform firmware update

Expected behavior

The firmware update is applied successfully and upon reboot, version is shown as v0.9.4.

Actual behavior

The update doesn't actually apply -- afterwards the version is still v0.9.3 and seemingly, no data got written.

Screenshots

No response

Additional context

I have uploaded logs from within DTS.

Solutions you've tried

I've also tried using the automated mode; however, that doesn't seem to work with DPP credentials. In that case, it says there isn't an update available (even if pressing 9 to get to DTS menu then 4 to enter credentials, then exiting and trying to do the automated update mode, it still never finds the new v0.9.4).

[laurelmay]

Based on when the failure occurs (immediately after the "This may take several minutes..." and the fact that "Scheduling main firmware update..." never appears), this seems to be an issue with the following line: https://github.com/Dasharo/dts-scripts/blob/15e6c41f33ef290161e1858609ccc31c0481d70a/scripts/dasharo-deploy.sh#L939

Because DTS proceeds with thinking the update was successful, it also seems likely that the subsequent return 0 should either be return $? or some equivalent check on the return code of $CAP_UPD_TOOL (like what's done in fuse_workflow).

[DaniilKl]

Hi @laurelmay, thank you for your report. We will take a look on what caused the issue.

Based on when the failure occurs (immediately after the "This may take several minutes..." and the fact that "Scheduling main firmware update..." never appears), this seems to be an issue with the following line: https://github.com/Dasharo/dts-scripts/blob/15e6c41f33ef290161e1858609ccc31c0481d70a/scripts/dasharo-deploy.sh#L939

Because DTS proceeds with thinking the update was successful, it also seems likely that the subsequent return 0 should either be return $? or some equivalent check on the return code of $CAP_UPD_TOOL (like what's done in fuse_workflow).

And more precisely it happened here: https://github.com/Dasharo/dts-scripts/blob/e5baef21d0a30f3a1d888572860b3e37b649164d/include/hal/dts-hal.sh#L185

As according to the logs you sent us:

+[19:41:00.249]:/usr/sbin/dasharo-deploy:890:deploy_firmware: '[' dpp_cap == dpp_cap ']'
+[19:41:00.251]:/usr/sbin/dasharo-deploy:893:deploy_firmware: tool_wrapper cap_upd_tool /tmp/biosupdate
+[19:41:00.252]:/usr/sbin/dts-hal.sh:103:tool_wrapper: local _tool=cap_upd_tool
+[19:41:00.254]:/usr/sbin/dts-hal.sh:105:tool_wrapper: local _mock_func=/tmp/biosupdate
+[19:41:00.255]:/usr/sbin/dts-hal.sh:109:tool_wrapper: echo /tmp/biosupdate
+[19:41:00.256]:/usr/sbin/dts-hal.sh:109:tool_wrapper: grep _mock
+[19:41:00.258]:/usr/sbin/dts-hal.sh:110:tool_wrapper: unset _mock_func
+[19:41:00.259]:/usr/sbin/dts-hal.sh:111:tool_wrapper: shift 1
+[19:41:00.260]:/usr/sbin/dts-hal.sh:117:tool_wrapper: _arguments=('/tmp/biosupdate')
+[19:41:00.262]:/usr/sbin/dts-hal.sh:117:tool_wrapper: local _arguments
+[19:41:00.263]:/usr/sbin/dts-hal.sh:119:tool_wrapper: '[' -n '' ']'
+[19:41:00.264]:/usr/sbin/dts-hal.sh:139:tool_wrapper: cap_upd_tool /tmp/biosupdate
+[19:41:00.265]:/usr/sbin/dts-hal.sh:183:cap_upd_tool: local _capsule=/tmp/biosupdate
+[19:41:00.266]:/usr/sbin/dts-hal.sh:185:cap_upd_tool: cat /tmp/biosupdate
+[19:41:00.283]:/usr/sbin/dts-hal.sh:187:cap_upd_tool: return 1
+[19:41:00.284]:/usr/sbin/dts-hal.sh:143:tool_wrapper: ret=1
+[19:41:00.285]:/usr/sbin/dts-hal.sh:144:tool_wrapper: echo 'cap_upd_tool /tmp/biosupdate 1'
+[19:41:00.285]:/usr/sbin/dts-hal.sh:145:tool_wrapper: echo '/usr/sbin/dasharo-deploy:deploy_firmware:893 cap_upd_tool /tmp/biosupdate 1'
+[19:41:00.286]:/usr/sbin/dts-hal.sh:147:tool_wrapper: return 1
+[19:41:00.286]:/usr/sbin/dasharo-deploy:896:deploy_firmware: return 0
+[19:41:00.287]:/usr/sbin/dasharo-deploy:1123:update_workflow: '[' '!' -z '' ']'

DTS does not check the return value of the call to cap_upd_tool(). The function failed and returned 1, and this fact was not caught.

The reason the cat command in the cap_upd_tool() failed is yet to be found.

Btw. DTS v2.7.2 uses scripts from repository Dasharo/dts-scripts from commit e5baef21d0a30f3a1d888572860b3e37b649164d. So make sure that when you are debugging things you are searching the correct codebase :) . Thank you for your inquiry, though.

[iwanicki92]

This might be due to ME not being set to HAP disabled. Docs don't mention anything about FUM disabling ME: https://docs.dasharo.com/kb/firmware-update-mode/ so it's possible it's enabled.