[Bug] Go to definition does not work for `make`

[BigBoyBarney]

Hi!

This doesn't happen with my own proc groups, only with make:

x := make([]int, 4, context.temp_allocator) // Goes to a seemingly random make definition or call.

one :: proc(x: int) {}
two :: proc(y: bool) {}
three :: proc() {}

test :: proc {
    one,
    two,
    three,
}

test() // goes to the proc group

Video:

Example.mp4

---

Cheers!

[BradLewis]

The make example here is actually the desired behaviour. Similar to how hover works, it will take you to the actual function that will be called. In the video you can see it takes you to make_slice as you're trying to make a slice. If we didn't do this and instead took you to the proc group definition, you would then need to try to infer which option would be called, allowing you to instead just follow the call graph.

In your example where it takes you to the group, I think this is because you haven't passed any parameters but I'll take a look at it and try to make it the same as the make example Edit: seems like it's not that but I'll take a look at it.

Edit Edit: actually I think I was wrong with this, you can see it's actually taking you to all definitions of make (including the proc group).

[BigBoyBarney]

I should have specified what I expected to happen in the issue, sorry!

I would have expected it to either:

• take me to the proc group
• take me to the proc that's going to be called

But you can see in the video, it shows me all of the make procs, and when I clicked "go to definition" the 2nd time in the video, it actually took me to make_soa_slice.

make_soa_slice seems to be the most common target, for example make(map[int]struct{}, 20, context.temp_allocator) takes me to make_soa_slice as well.

Thank you for taking a look!

[BradLewis]

This might be a good use for textDefinition/implementation. We could make textDefinition/definition take to you to proc group and textDefinition/implementation take you to the actually proc implemention, similarly to how it works with interfaces in other languages.

[BigBoyBarney]

This seems to affect all built-in procedure groups, like clear etc.