Skip to content

[chart/redis-ha][REQUEST] Make labels for the chart version overridable or strip digest from the Version #370

@amferguson

Description

@amferguson

Is your feature request related to a problem? Please describe.
I've noticed that when trying to deploy this chart via a HelmRelease in Flux, the default behavior of the HelmController is causing an issue. As an example, the chart label template ({{ .Chart.Name }}-{{ .Chart.Version }}) in the redis-ha-serviceaccount.yaml template results in an invalid label because the HelmController appends the digest (e.g. +abc123), and + is not allowed. This same pattern seems to be true for most of the templates, and not just the ServiceAccount.

Describe the solution you'd like
Can we maybe make this something that could be overwritten in the chart's Values OR simply transform the .Chart.Version part to remove the + and any characters after it if they are there?

Describe alternatives you've considered
I've been playing with trying to supply the "real" chart version from a ConfigMap and transforming it with Kustomize, but it's getting a little complicated in terms of the interacting replacements, patches, etc.. It's possible that I am just overcomplicating that part, though.

Additional context
None that I can think of, but I'm happy to provide more information if it will help!

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions