From 5d8f037d251e7a568fcc387a96f2611f247f1024 Mon Sep 17 00:00:00 2001 From: Tony Guntharp Date: Wed, 18 Mar 2026 12:46:20 -0500 Subject: [PATCH] fix: gemspec authors/email and use PER_PAGE constant - #60: Second spec.authors was overwriting authors with email. Changed to spec.email. - #61: PER_PAGE constant (50) was defined but never used. Now used as default when per_page param is not provided. Closes #60 Closes #61 --- app/controllers/paper_trail_manager/changes_controller.rb | 2 +- paper_trail_manager.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/paper_trail_manager/changes_controller.rb b/app/controllers/paper_trail_manager/changes_controller.rb index 6458506..135fb0a 100644 --- a/app/controllers/paper_trail_manager/changes_controller.rb +++ b/app/controllers/paper_trail_manager/changes_controller.rb @@ -28,7 +28,7 @@ def index @page = nil if @page.zero? @per_page = params[:per_page].to_i - @per_page = nil if @per_page.zero? + @per_page = PER_PAGE if @per_page.zero? @versions = if defined?(WillPaginate) @versions.paginate(page: @page, per_page: @per_page) diff --git a/paper_trail_manager.gemspec b/paper_trail_manager.gemspec index 616d656..b1f09db 100644 --- a/paper_trail_manager.gemspec +++ b/paper_trail_manager.gemspec @@ -7,7 +7,7 @@ Gem::Specification.new do |spec| spec.name = 'paper_trail_manager' spec.version = '0.8.0' spec.authors = ['Igal Koshevoy', 'Reid Beels'] - spec.authors = ['mail@reidbeels.com'] + spec.email = ['mail@reidbeels.com'] spec.summary = 'A user interface for `paper_trail` versioning data in Rails applications.' spec.description = 'Browse, subscribe, view and revert changes to records when using Rails and the `paper_trail` gem.' spec.homepage = 'https://github.com/DamageLabs/paper_trail_manager'