From 56726ed59de5a0a9a1f01e7899263274bbb02f51 Mon Sep 17 00:00:00 2001
From: odrling <florianbadie@odrling.xyz>
Date: Sat, 7 Feb 2026 19:05:05 +0100
Subject: [PATCH] make LOG_FILE_PATH an optional production config value
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In our deployment in kubernetes[1] we usually use the standard output of
the service which is captured by k8s, so the logs can be read from any
tool in the k8s ecosystem.
Setting LOG_FILE_PATH to /dev/stdout doesn’t work as RotatingFileHandler
needs a seekable file to work correctly (needs to tell the current file
position to rotate the logs).

So this allows to use the standard output for logs when LOG_FILE_PATH is
not set.

[1]: https://github.com/Japan7/nanak8s
---
 .../dakara_server/settings/production.py      | 33 ++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/dakara_server/dakara_server/settings/production.py b/dakara_server/dakara_server/settings/production.py
index 3b8b0c0c..98befdd1 100644
--- a/dakara_server/dakara_server/settings/production.py
+++ b/dakara_server/dakara_server/settings/production.py
@@ -46,6 +46,22 @@
 
 TIME_ZONE = config("TIME_ZONE", default="UTC")
 
+logfile_handler = {}
+handlers = ["console_playlist"]
+if config("LOG_FILE_PATH", default=""):
+    logfile_handler = {
+        "logfile": {
+            "level": "DEBUG",
+            "class": "logging.handlers.RotatingFileHandler",
+            "filename": config("LOG_FILE_PATH"),
+            "maxBytes": config("LOG_FILE_MAX_SIZE", cast=int),
+            "backupCount": config("LOG_FILE_BACKUP_COUNT", cast=int),
+            "formatter": "default",
+        },
+    }
+    handlers = ["logfile"]
+
+
 # Loggin config
 LOGGING = {
     "version": 1,
@@ -69,19 +85,12 @@
             "class": "logging.StreamHandler",
             "formatter": "no_time",
         },
-        "logfile": {
-            "level": "DEBUG",
-            "class": "logging.handlers.RotatingFileHandler",
-            "filename": config("LOG_FILE_PATH"),
-            "maxBytes": config("LOG_FILE_MAX_SIZE", cast=int),
-            "backupCount": config("LOG_FILE_BACKUP_COUNT", cast=int),
-            "formatter": "default",
-        },
+        **logfile_handler,
     },
     "loggers": {
-        "playlist.views": {"handlers": ["logfile"], "level": "INFO"},
-        "playlist.date_stop": {"handlers": ["logfile"], "level": "INFO"},
-        "playlist.consumers": {"handlers": ["logfile"], "level": "INFO"},
+        "playlist.views": {"handlers": handlers, "level": "INFO"},
+        "playlist.date_stop": {"handlers": handlers, "level": "INFO"},
+        "playlist.consumers": {"handlers": handlers, "level": "INFO"},
         "library.management.commands.feed": {
             "handlers": ["console_interactive"],
             "level": "INFO",
@@ -91,7 +100,7 @@
             "level": "INFO",
         },
         "django": {
-            "handlers": ["logfile"],
+            "handlers": handlers,
             "level": config("DJANGO_LOG_LEVEL", default="INFO"),
         },
     },