Skip to content

Several compiler warnings when built with e26:prof qualifier #15

@MRiganSUSX

Description

@MRiganSUSX
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerChannelDistance.cpp: In member function ‘virtual void triggeralgs::TriggerActivityMakerChannelDistance::operator()(const triggeralgs::TriggerPrimitive&, std::vector<triggeralgs::TriggerActivity>&)’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerChannelDistance.cpp:49:24: warning: comparison of integer expressions of different signedness: ‘const dunedaq::trgdataformats::channel_t’ {aka ‘const int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
   49 |   if (input_tp.channel > m_current_upper_bound || input_tp.channel < m_current_lower_bound)
      |       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerChannelDistance.cpp:49:68: warning: comparison of integer expressions of different signedness: ‘const dunedaq::trgdataformats::channel_t’ {aka ‘const int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
   49 |   if (input_tp.channel > m_current_upper_bound || input_tp.channel < m_current_lower_bound)
      |                                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerHorizontalMuon.cpp: In member function ‘uint16_t triggeralgs::TriggerActivityMakerHorizontalMuon::check_adjacency() const’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerHorizontalMuon.cpp:229:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  229 |   for (int i = 0; i < chanList.size(); ++i) {
      |                   ~~^~~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerHorizontalMuon.cpp:256:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  256 |       for (int i = 0; i < next_channel - channel; ++i) {
      |                       ~~^~~~~~~~~~~~~~~~~~~~~~~~

and

[ 52%] Building CXX object dunetrigger/dunetrigger/triggeralgs/CMakeFiles/triggeralgs_module.dir/src/TriggerActivityMakerPrescale.cpp.o
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp: In member function ‘std::vector<dunedaq::trgdataformats::TriggerPrimitive> triggeralgs::TriggerActivityMakerMichelElectron::longest_activity() const’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp:144:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<dunedaq::trgdataformats::TriggerPrimitive>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  144 |   for (int i = 0; i < hitList.size(); ++i) {
      |                   ~~^~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp:172:26: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  172 |       for (int i = 0 ; i < next_channel-channel ; ++i){ ++tol_count; }
      |                        ~~^~~~~~~~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp: In member function ‘bool triggeralgs::TriggerActivityMakerMichelElectron::check_kinks(std::vector<dunedaq::trgdataformats::TriggerPrimitive>)’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp:260:22: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<dunedaq::trgdataformats::TriggerPrimitive>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  260 |     for (int i=0 ; i < finalHits.size()-2; i++){
      |                    ~~^~~~~~~~~~~~~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/TriggerActivityMakerMichelElectron.cpp:287:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<float>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  287 |       for(int g=0 ; g < runningGradient.size()-1 ; g++){
      |                     ~~^~~~~~~~~~~~~~~~~~~~~~~~~~

and

[ 75%] Building CXX object dunetrigger/dunetrigger/triggeralgs/CMakeFiles/triggeralgs_module.dir/src/dbscan/Hit.cpp.o
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/dbscan/Hit.cpp: In member function ‘bool triggeralgs::dbscan::Hit::add_potential_neighbour(triggeralgs::dbscan::Hit*, float, int)’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/dbscan/Hit.cpp:64:35: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
   64 |         if (neighbours.size() + 1 >= minPts) {
      |             ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/dbscan/Hit.cpp:69:42: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
   69 |         if (other->neighbours.size() + 1 >= minPts) {
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/dbscan/dbscan.cpp: In member function ‘bool triggeralgs::dbscan::Cluster::maybe_add_new_hit(triggeralgs::dbscan::Hit*, float, int)’:
/exp/dune/app/users/mrigan/dunetrigger/srcs/dunetrigger/dunetrigger/triggeralgs/src/dbscan/dbscan.cpp:46:42: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
   46 |             if (h->neighbours.size() + 1 >= minPts) {
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
[ 77%] Linking CXX shared library ../../slf7.x86_64.e26.prof/lib/libtriggeralgs_module.so
lto-wrapper: warning: using serial compilation of 13 LTRANS jobs
lto-wrapper: note: see the ‘-flto’ option documentation for more information
[ 77%] Built target triggeralgs_module

Unsure whether the issue should be opened here or in triggeralgs. Technically, the code affecting this is in triggeralgs, but the warnings do not show up when built for dunedaq, only when built as dunetrigger with dunesw...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions