forked from coingecko/cryptoexchange
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathPULL_REQUEST_TEMPLATE
More file actions
15 lines (13 loc) · 865 Bytes
/
PULL_REQUEST_TEMPLATE
File metadata and controls
15 lines (13 loc) · 865 Bytes
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
- What is the purpose of this Pull Request?
- What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?
- [ ] I have added Specs
- [ ] (If implementing Market Ticker) I have verified that the `volume` refers to BASE
- [ ] (If implementing Market Ticker) I have verified that the `base` and `target` is assigned correctly
- [ ] I have implemented the `trade_page_url` method that links to the exchange page with the `base` and `target` passed in. If not available, enter the root domain of the exchange website.
- [ ] I have verified at least **ONE** ticker volume matches volume shown on the trading page (use script below)
```
client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse
```