omg a

Author: BlueWitherer

include/Horrible.hpp

@@ -132,7 +132,7 @@ namespace horrible {
      * @param id The ID of the option to delegate for
      * @param hooks The map of hooks to delegate
      */
-    AWCW_HORRIBLE_API_DLL void delegateHooks(std::string_view id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
+    AWCW_HORRIBLE_API_DLL void delegateHooks(std::string id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
 };
 
 // Statically register an option
@@ -143,5 +143,5 @@ namespace horrible {
 // Delegate registered hooks to OptionManager for dynamic toggling
 #define HORRIBLE_DELEGATE_HOOKS(id) \
 static void onModify(auto& self) { \
-    horrible::delegateHooks(std::string_view(id), self.m_hooks); \
+    horrible::delegateHooks(id, self.m_hooks); \
 }

src/include/Horrible.cpp

@@ -81,7 +81,7 @@ OptionManager* OptionManager::get() noexcept {
     return inst;
 };
 
-void horrible::delegateHooks(std::string_view id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks) {
+void horrible::delegateHooks(std::string id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks) {
     if (auto om = OptionManager::get()) {
         auto value = om->getOption(id);
 
@@ -95,7 +95,7 @@ void horrible::delegateHooks(std::string_view id, geode::utils::StringMap<std::s
         geode::log::debug("Delegating {} hooks for {}", allHooks.size(), id);
 
         om->addDelegate(
-            std::string(id), // string buffers die on other platforms ???
+            std::move(id), // string buffers die here on other platforms ???
             [allHooks = std::move(allHooks)](bool value) {
                 for (auto hook : allHooks) (void)hook->toggle(value);
             }