clean code

Author: BlueWitherer

include/README.md

@@ -223,7 +223,7 @@ These classes mirror the main API but return `geode::Result` values so callers c
 #### class `horrible::OptionManagerV2`
 - `static Result<>` **`registerOption(Option const& option)`**
 - `static Result<bool>` **`getOption(std::string_view id)`**
-- `static Result<bool>` **`setOption(std::string const& id, bool enable)`**
+- `static Result<bool>` **`setOption(std::string_view id, bool enable)`**
 
 #### Summary
 | Type    | Name                          | Description                          |

src/Utils.hpp

@@ -42,8 +42,8 @@ namespace horrible {
      *
      * @param name Name of the audio file
      */
-    inline void playSfx(std::string_view name) {
-        if (auto fmod = FMODAudioEngine::sharedEngine()) fmod->playEffectAsync(name.data());
+    inline void playSfx(const char* file) {
+        if (auto fmod = FMODAudioEngine::sharedEngine()) fmod->playEffectAsync(file);
     };
 
     namespace str = utils::string; // Shortcut for geode::utils::string

src/hooks/Achievement.cpp

@@ -1,4 +1,5 @@
 #include <Utils.hpp>
+
 #include <Geode/modify/CCMenuItem.hpp>
 
 using namespace horrible;

src/hooks/Mock.cpp

@@ -1,3 +1,4 @@
+#if !defined(GEODE_IS_MACOS) && !defined(GEODE_IS_IOS) // not available for these platforms
 #include <Utils.hpp>
 
 #include <Geode/modify/MenuLayer.hpp>
@@ -115,7 +116,6 @@ class $modify(MockPlayLayer, PlayLayer) {
         log::info("Showing new best for level ID: {}", id);
         log::info("Level percentage: {}", percentage);
 
-#if !defined(GEODE_IS_MACOS) && !defined(GEODE_IS_IOS) // not available for these platforms
         if (m_fields->enabled && percentage >= 90) {
             CCDirector* director = CCDirector::sharedDirector();
             CCScene* scene = CCScene::get();
@@ -173,7 +173,6 @@ class $modify(MockPlayLayer, PlayLayer) {
                 log::error("Failed to create image from render texture");
             };
         };
-#endif
 
         PlayLayer::showNewBest(newReward, orbs, diamonds, demonKey, noRetry, noTitle);
     };
@@ -203,4 +202,5 @@ class $modify(MockPlayLayer, PlayLayer) {
 
         PlayLayer::levelComplete();
     };
-};
+};
+#endif