Skip to content

Thai Date Viewing/Saving Bug #578

@jamesduncan

Description

@jamesduncan

Short Description

When viewing or saving a date with Thai set as the user's default language an issue with display the date improperly and saving the date incorrectly can occur.

Does the bug prevent users from working?

The bug prevents users from completing critical tasks (e.g., saving data)

Steps to Reproduce

  1. Go to https://design.digiserve.org/
  2. Click on FCF HR App in apps list under the hamburger menu.
  3. Under the main FCF HR App filter the users to "James" and click on "James Duncan" cog after hovering over the record.
  4. Notice the birthdate ("11/06/1982" which is November 6, 1982 if you view in calendar)
    Image
  5. Notice the "Cal HBD Reminder" ("11/06/1982 12:00 PM" which is November 6, 1982 12:00 PM if you view in calendar)
    Image
  6. Switch user default launguage to "Thai" in "User Profile" popup (found under user icon in top right hand of page)
  7. Reload the site and view the "James Duncan" record again.
  8. Notice the dates have shifted under birthday (month and day swapped)
    Image
  9. Notice the same for the calendar reminder
    Image
  10. Click on "Save" without making any changes.
  11. Reload the page.
  12. View the same "James Duncan" record.
  13. Notice the birthday has changed to a new date.
    Image
  14. Notice the calendar reminder has saved properly.
  15. Change the language back to "English"
  16. Notice the birthday still has the incorrect value.
  17. Notice the reminder date while correct when display Thai version is not correct in English.
    Image

Expected Behavior

When saving dates we should respect the original date format.

What Server are you using?

All instances of AppBuilder

Screenshots

No response

Anything else?

Most of these issues could simply be related to the fact that we are formatting the day and month differently when swapping between English and Thai and it needs to be addressed when modifying the date.

The issue with saving the date in Thai version and it reverting back to January 1st...I don't know why that would happen. My recommendation would be to remove the support for Thai year completely for now until it can be addressed and tests written around it. I know that there are other areas this bug is affecting when working with record rules as well so this is just a bit of a bigger issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions