Asset creation processes

[defunctec]

Starting a thread to track issues relating to asset creation.
Please post any bugs you find relating to asset creation here.

GUI
Attempting to create an NFT without selecting any properties results with a tx which cannot be added to mempool because as it states within the debug "Transaction cannot be broadcast immediately, invalid properties, asset type is Unique, but is not marked limited". This is correct but the GUI should throw an error before attempting to add to mempool.

[defunctec]

GUI
Attempting to create NFT using "Convertible" property crashes the wallet

[BlockMechanic]

Seen, reproducing for test and will resolve

[defunctec]

Same with 0.83

And
ERROR: VerifyDB: *** found bad block at 5964, hash=572acb8791cda0204eab3c319426ffa3e5a4e54c623437fa354704d3fa79ec93 (Contract name already reserved

[defunctec]

Please please please consider all occurrences of potential property selection failure.

[BlockMechanic]

Please please please consider all occurrences of potential property selection failure.

See here : - https://github.com/Crowndev/crown/blob/main/src/wallet/wallet.cpp#L3316 that's the check DURING creation.

See here : - https://github.com/Crowndev/crown/blob/main/src/consensus/tx_check.cpp#L45 that's the consensus level check.

Will investigate, but this case should be covered as evidenced by it rejecting the block, likely you have a bad DB, try a re-sync. not reindex

[BlockMechanic]

Found the missing case. more to come

[defunctec]

When creating a contract you can make one using a shortname(symbol) which already exists.
This causes a problem when creating an asset, since you cannot use the same symbol twice (as it should be).

[defunctec]

Using numbers only as Asset name results in failed tx to mempool

[BlockMechanic]

symbol issue should be resolved in next release. Not sure about the second item though, i am not a fan of too much limits, i'll see if a workaround is solid or to prevent numbers.