Skip to content

Deletion of a dataset not reflected in aggregation list #531

@jrwrigh

Description

@jrwrigh

Description

If I add a dataset to aggregation list and then delete that dataset, the aggregation list still believes the dataset exists.

How to reproduce

from smartsim import Experiment
from smartsim.settings import RunSettings
from smartredis import Client, Dataset
import numpy as np

import socket
def getOpenSocket():
    s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    s.bind(('', 0))
    addr = s.getsockname()
    s.close()
    return addr[1]

exp = Experiment("test", launcher="local")
db = exp.create_database(interface="lo", port = getOpenSocket())
exp.generate(db)
exp.start(db)

client = Client(cluster=False, address=db.get_address()[0])

dataset = Dataset("dataset")
dataset.add_tensor("data", np.arange(3))
client.put_dataset(dataset)
client.append_to_list("list", dataset)

print(client.get_datasets_from_list("list")[0].get_name()) # returns "dataset"
print(client.get_datasets_from_list("list")[0].get_tensor_names()) # returns ["data"]

client.delete_dataset("dataset")

print(client.get_datasets_from_list("list")[0].get_name()) # returns "dataset"
print(client.get_datasets_from_list("list")[0].get_tensor_names()) # returns []
client.get_dataset(client.get_datasets_from_list("list")[0].get_name()) # errors

Expected behavior

I'd expect the dataset to also be deleted in the list. Or at least have someway to remove datasets from a list.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugGeneral bug tag before severity classification

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions