fix(config): add validation for threshold, ratio, and token count fields

Author: echobt

src/cortex-compact/src/config.rs

@@ -1,15 +1,15 @@
 //! Compaction configuration.
 
-use serde::{Deserialize, Serialize};
+use serde::{Deserialize, Deserializer, Serialize};
 
 /// Configuration for auto-compaction.
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct CompactionConfig {
     /// Whether auto-compaction is enabled.
     #[serde(default = "default_true")]
     pub enabled: bool,
-    /// Token threshold to trigger compaction (percentage of max).
-    #[serde(default = "default_threshold")]
+    /// Token threshold to trigger compaction (ratio 0.0-1.0 of max context).
+    #[serde(default = "default_threshold", deserialize_with = "deserialize_threshold_percent")]
     pub threshold_percent: f32,
     /// Minimum tokens to keep after compaction.
     #[serde(default = "default_min_tokens")]
@@ -25,6 +25,20 @@ pub struct CompactionConfig {
     pub preserve_recent_turns: usize,
 }
 
+/// Deserialize threshold_percent with validation (must be 0.0-1.0).
+fn deserialize_threshold_percent<'de, D>(deserializer: D) -> Result<f32, D::Error>
+where
+    D: Deserializer<'de>,
+{
+    let value = f32::deserialize(deserializer)?;
+    if !(0.0..=1.0).contains(&value) {
+        return Err(serde::de::Error::custom(
+            "threshold_percent must be between 0.0 and 1.0",
+        ));
+    }
+    Ok(value)
+}
+
 fn default_true() -> bool {
     true
 }

src/cortex-engine/src/config/mod.rs

@@ -46,9 +46,9 @@ pub struct Config {
     /// Provider configuration.
     pub model_provider: ModelProviderInfo,
     /// Context window size.
-    pub model_context_window: Option<i64>,
+    pub model_context_window: Option<u64>,
     /// Auto-compact token limit.
-    pub model_auto_compact_token_limit: Option<i64>,
+    pub model_auto_compact_token_limit: Option<u64>,
     /// Approval policy.
     pub approval_policy: AskForApproval,
     /// Sandbox policy.

src/cortex-engine/src/config/types.rs

@@ -69,8 +69,8 @@ pub struct PermissionConfig {
 pub struct ConfigToml {
     pub model: Option<String>,
     pub model_provider: Option<String>,
-    pub model_context_window: Option<i64>,
-    pub model_auto_compact_token_limit: Option<i64>,
+    pub model_context_window: Option<u64>,
+    pub model_auto_compact_token_limit: Option<u64>,
     pub approval_policy: Option<AskForApproval>,
     pub sandbox_mode: Option<SandboxMode>,
     pub sandbox_workspace_write: Option<SandboxWorkspaceWrite>,

src/cortex-otel/src/config.rs

@@ -1,6 +1,6 @@
 //! OpenTelemetry configuration.
 
-use serde::{Deserialize, Serialize};
+use serde::{Deserialize, Deserializer, Serialize};
 
 /// OpenTelemetry settings.
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -30,14 +30,28 @@ pub struct OtelSettings {
     pub propagate_context: bool,
 
     /// Sampling ratio (0.0 to 1.0).
-    #[serde(default = "default_sampling_ratio")]
+    #[serde(default = "default_sampling_ratio", deserialize_with = "deserialize_sampling_ratio")]
     pub sampling_ratio: f64,
 
     /// Export timeout in seconds.
     #[serde(default = "default_export_timeout")]
     pub export_timeout_secs: u64,
 }
 
+/// Deserialize sampling_ratio with validation (must be 0.0-1.0).
+fn deserialize_sampling_ratio<'de, D>(deserializer: D) -> Result<f64, D::Error>
+where
+    D: Deserializer<'de>,
+{
+    let value = f64::deserialize(deserializer)?;
+    if !(0.0..=1.0).contains(&value) {
+        return Err(serde::de::Error::custom(
+            "sampling_ratio must be between 0.0 and 1.0",
+        ));
+    }
+    Ok(value)
+}
+
 impl Default for OtelSettings {
     fn default() -> Self {
         OtelSettings {
@@ -84,7 +98,8 @@ impl OtelSettings {
         }
 
         if let Ok(ratio) = std::env::var("OTEL_TRACES_SAMPLER_ARG")
-            && let Ok(ratio) = ratio.parse()
+            && let Ok(ratio) = ratio.parse::<f64>()
+            && (0.0..=1.0).contains(&ratio)
         {
             settings.sampling_ratio = ratio;
         }

src/cortex-protocol/src/protocol/event_payloads.rs

@@ -40,7 +40,7 @@ pub struct SessionConfiguredEvent {
 
 #[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)]
 pub struct TaskStartedEvent {
-    pub model_context_window: Option<i64>,
+    pub model_context_window: Option<u64>,
 }
 
 #[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)]

src/cortex-protocol/src/protocol/tokens.rs

@@ -18,7 +18,7 @@ pub struct TokenUsage {
 pub struct TokenUsageInfo {
     pub total_token_usage: TokenUsage,
     pub last_token_usage: TokenUsage,
-    pub model_context_window: Option<i64>,
+    pub model_context_window: Option<u64>,
     #[serde(default)]
     pub context_tokens: i64,
 }