Skip to content

Recognize BIP352 Silent Payment addresses and suppress false-positive address reuse #52

@satsfy

Description

@satsfy

Problem

BIP352 (Silent Payments) was adopted in Bitcoin Core 28.0+ (v1.1.0, March 2, 2026). Silent Payments allow a recipient to publish a single static address while receiving to a unique derived P2TR output for every payment. By protocol design, the scanning key holder can receive unlimited payments to distinct on-chain addresses that all derive from the same silent payment address.

The current analyzeAddressReuse() function in address-reuse.ts has no awareness of Silent Payment addresses. As SP adoption grows, users who receive multiple payments to their SP address will see each derived output as a separate P2TR address. While the on-chain addresses themselves are unique (no actual address reuse), the tool should:

  1. Recognize SP-derived outputs and note them as privacy-positive (SP eliminates address reuse by design).
  2. Recommend BIP352 migration as a remediation for h8-address-reuse findings on non-SP addresses.

Scope

This issue does not require full SP scanning (which would need the recipient's scan key). It covers:

  1. Updating remediation text for h8-address-reuse to mention Silent Payments as a permanent fix.
  2. Adding SP awareness to wallet-level analysis if a user provides an SP address (starts with sp1 on mainnet).
  3. Future-proofing the address type detection in address-type.ts to recognize sp1 prefix.

Proposed changes

  • address-type.ts: Add "sp" to the AddressType union and detect sp1 prefix for mainnet.
  • address-reuse.ts: In remediation text for h8-address-reuse, add: "Consider migrating to a BIP352 Silent Payment address to eliminate address reuse by protocol design."
  • primary-recommendation.ts: When recommending against address reuse, include SP-capable wallets (Cake Wallet, Silentium, BlueWallet) in tool suggestions.

Acceptance criteria

  • sp address type recognized in address-type.ts
  • Remediation for address reuse mentions BIP352 Silent Payments
  • SP-capable wallets listed in tool recommendations
  • i18n keys for SP-related text

Metadata

Metadata

Assignees

Labels

analysisHeuristics, scoring, detection, Boltzmann, chain tracingenhancementImprove something that works

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions