Skip to content

Support id arg from cli #15

@ConorSheehan1

Description

@ConorSheehan1

Most docker commands take an id or a name. e.g. docker logs
Currently (v0.1.2) osxdocker only supports names.

def clear_log(self, container_name):

I see two main options:

  1. Use one arg and figure out if it's a name or an id.

    def clear_logs(container_name_or_id):
        # this could be complicated / have edgecases. 
        # need to look into constraints for valid names and ids.
        if(container_name_or_id is name):
            # do something to convert to id
  2. Use 2 kwargs.
    Would make cli more verbose, but handle edgecases.
    e.g. osxdocker clear_log --name foo instead of osxdocker clear_log foo.

    def getContainerId(id=None, name=None):
        if (name):
            # do something to convert to id
        return id

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions