From 68ed918cb153b9173f9b934f2a13ad58f53e9f20 Mon Sep 17 00:00:00 2001 From: Peter Doak Date: Wed, 6 Aug 2025 12:53:23 -0400 Subject: [PATCH 1/2] subtract with carry changed for gcc15 --- test/unit/math/random/std_random_wrapper_custom_seed_test.cpp | 4 ++-- .../unit/math/random/std_random_wrapper_default_seed_test.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp b/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp index 781088f3d..cc92bec4f 100644 --- a/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp +++ b/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp @@ -59,14 +59,14 @@ inline std::vector& getFirstRandomNumbersCustomSeed() { 0.24682368736319102, 0.88335484565944544}; return vec; } -#endif +#endif } // testing } // dca template class StdRandomWrapperTest : public ::testing::Test {}; -using Engines = ::testing::Types; +using Engines = ::testing::Types; // std::ranlux48_base, std::ranlux48>; TYPED_TEST_CASE(StdRandomWrapperTest, Engines); TYPED_TEST(StdRandomWrapperTest, CustomSeed) { diff --git a/test/unit/math/random/std_random_wrapper_default_seed_test.cpp b/test/unit/math/random/std_random_wrapper_default_seed_test.cpp index 4ff99bb51..94fa5b50c 100644 --- a/test/unit/math/random/std_random_wrapper_default_seed_test.cpp +++ b/test/unit/math/random/std_random_wrapper_default_seed_test.cpp @@ -66,7 +66,7 @@ inline std::vector& getFirstRandomNumbersDefaultSeed() { template class StdRandomWrapperTest : public ::testing::Test {}; -using Engines = ::testing::Types; +using Engines = ::testing::Types; //, std::ranlux48_base, std::ranlux48>; TYPED_TEST_CASE(StdRandomWrapperTest, Engines); TYPED_TEST(StdRandomWrapperTest, DefaultSeed) { From 46942ac7e1e8a439c820c9ed21f98625b308c080 Mon Sep 17 00:00:00 2001 From: Peter Doak Date: Fri, 15 Aug 2025 14:45:38 -0400 Subject: [PATCH 2/2] as of cce 18.0.1 ranlux rgd gens agree with gcc --- .../std_random_wrapper_custom_seed_test.cpp | 32 ++++++++--------- .../std_random_wrapper_default_seed_test.cpp | 34 ++++++++++--------- 2 files changed, 34 insertions(+), 32 deletions(-) diff --git a/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp b/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp index cc92bec4f..41495a064 100644 --- a/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp +++ b/test/unit/math/random/std_random_wrapper_custom_seed_test.cpp @@ -35,18 +35,18 @@ inline std::vector& getFirstRandomNumbersCustomSeed() { return vec; } -#if defined(__clang__) -template <> -inline std::vector& getFirstRandomNumbersCustomSeed() { - static std::vector vec{0.59121028582286772,0.1686617322410229, 0.076703898677588533,0.73282393484576336,0.3330563551366435}; - return vec; -} -template <> -inline std::vector& getFirstRandomNumbersCustomSeed() { - static std::vector vec{0.59121028582286772, 0.1686617322410229, 0.076703898677588533, 0.73282393484576336, 0.3330563551366435}; - return vec; -} -#else +// #if defined(__clang__) +// template <> +// inline std::vector& getFirstRandomNumbersCustomSeed() { +// static std::vector vec{0.59121028582286772,0.1686617322410229, +// 0.076703898677588533,0.73282393484576336,0.3330563551366435}; return vec; +// } +// template <> +// inline std::vector& getFirstRandomNumbersCustomSeed() { +// static std::vector vec{0.59121028582286772, 0.1686617322410229, 0.076703898677588533, +// 0.73282393484576336, 0.3330563551366435}; return vec; +// } +// #else template <> inline std::vector& getFirstRandomNumbersCustomSeed() { static std::vector vec{0.0068332189419341447, 0.86802894579254541, 0.25453437079295799, @@ -59,14 +59,14 @@ inline std::vector& getFirstRandomNumbersCustomSeed() { 0.24682368736319102, 0.88335484565944544}; return vec; } -#endif -} // testing -} // dca + +} // namespace testing +} // namespace dca template class StdRandomWrapperTest : public ::testing::Test {}; -using Engines = ::testing::Types; // std::ranlux48_base, std::ranlux48>; +using Engines = ::testing::Types; TYPED_TEST_CASE(StdRandomWrapperTest, Engines); TYPED_TEST(StdRandomWrapperTest, CustomSeed) { diff --git a/test/unit/math/random/std_random_wrapper_default_seed_test.cpp b/test/unit/math/random/std_random_wrapper_default_seed_test.cpp index 94fa5b50c..28f66c64f 100644 --- a/test/unit/math/random/std_random_wrapper_default_seed_test.cpp +++ b/test/unit/math/random/std_random_wrapper_default_seed_test.cpp @@ -35,18 +35,20 @@ inline std::vector& getFirstRandomNumbersDefaultSeed() 0.79004886762619775, 0.73670732232143421}; return vec; } -#if defined (__clang__) -template <> -inline std::vector& getFirstRandomNumbersDefaultSeed() { - static std::vector vec{0.67052872832964927, 0.89987293212401465, 0.48383422722711483,0.28699620000273923,0.37575706648963081}; - return vec; -} -template <> -inline std::vector& getFirstRandomNumbersDefaultSeed() { - static std::vector vec{0.67052872832964927, 0.89987293212401465, 0.48383422722711483,0.28699620000273923,0.37575706648963081}; - return vec; -} -#else +// #if defined(__clang__) +// template <> +// inline std::vector& getFirstRandomNumbersDefaultSeed() { +// static std::vector vec{0.67052872832964927, 0.89987293212401465, 0.48383422722711483, +// 0.28699620000273923, 0.37575706648963081}; +// return vec; +// } +// template <> +// inline std::vector& getFirstRandomNumbersDefaultSeed() { +// static std::vector vec{0.67052872832964927, 0.89987293212401465, 0.48383422722711483, +// 0.28699620000273923, 0.37575706648963081}; +// return vec; +// } +// #else template <> inline std::vector& getFirstRandomNumbersDefaultSeed() { static std::vector vec{0.72777987290424495, 0.6717218115467265, 0.67916691101138849, @@ -59,14 +61,14 @@ inline std::vector& getFirstRandomNumbersDefaultSeed() { 0.040260746353792579, 0.94799739988482223}; return vec; } -#endif -} // testing -} // dca + +} // namespace testing +} // namespace dca template class StdRandomWrapperTest : public ::testing::Test {}; -using Engines = ::testing::Types; //, std::ranlux48_base, std::ranlux48>; +using Engines = ::testing::Types; TYPED_TEST_CASE(StdRandomWrapperTest, Engines); TYPED_TEST(StdRandomWrapperTest, DefaultSeed) {