[Bug] Radios sometimes aren't assigned correctly at mission start

[empollak]

Describe the bug
Sometimes, players have the correct radios but they are all on channel 1 when they should be otherwise.

This is because they have an ACRE2 field in their EDEN attributes which overwrites the framework channel settings.

This field is present on all newly placed units.

The reason it's been inconsistent is because the default units are old enough that they were placed before this feature existed. If the mission maker doesn't open and close the unit's attributes, they do not get the new field and don't get their radios overwritten.

To Reproduce
Steps to reproduce the behavior:

1. In default mission, open and close unit attributes window (double click on them, then press OK) for a unit with radios set to something other than channel 1 in acre_radio_configuration.
2. Start mission.
3. Observe that they are on channel 1.

Expected behavior
Radios go where they should

Screenshots
If applicable, add screenshots to help explain your problem.

Environmental Info(please complete the following information):

• V+
• No CDLC
• v1.8.2

Additional context
This setup is run by acre_api_setupRadios

[empollak]

Here's what's happening right now:

Stage	Effect
Expressions of Eden Editor entity attributes are called	Sets acre_sys_radio_setup to channel 1
Object init fields are called	Gearscript happens, which calls our configureUnitRadios
CBA PostInit handlers	Code to call setupRadios stores value of acre_sys_radio_setup, and then waits until ACRE is initialized
acre_api_isInitialized returns true	setupRadios is called, and waitsUntil ACRE is initialized
Next frame	setupRadios configures the radios based on the earlier grabbed value of acre_sys_radio_setup

I think there are three options:

1. Add the following code to radio init_component. This waits until ACRE is initialized, and then waits 5 seconds to make sure setupRadios has finished running.

[
	{
		[] call acre_api_fnc_isInitialized // Wait until ACRE is initialized 
	},
	{
		DEBUG_FORMAT1_LOG("[RADIO-2] Acre initialized for player %1, waiting for 5s", player);
		[
			{
				private _typeOfUnit = player getVariable ["f_var_assignGear", ""];

				private _faction = faction player;
				DEBUG_FORMAT1_LOG("[RADIO-2] Calling configureUnitRadios for player %1",_unit);
				[_typeOfUnit, _unit, _faction, []] call f_fnc_configureUnitRadios;
			},
			_this,
			5
		] call CBA_fnc_waitAndExecute;
	}
] call CBA_fnc_waitUntilAndExecute;

2. The same as above except instead of waiting for 5 seconds, nest a couple more checks for isInitialized, to get past the check in setupRadios in the CBA execution order

3. Add (_this select 1) setVariable ["acre_sys_radio_setup", "[]"]; to gearscript's assignGear. This overwrites the variable set by the EDEN attribute, and because it happens at the object init stage, it happens before the ACRE code grabs it. The downside is it gets redundantly set every time gearscript happens.

I went with 3 because it seems like the cleanest and doesn't rely on timing that could theoretically maybe get messed up, though it comes with one extra variable set every once in a while.

[empollak]

Here's the commit that added this IDI-Systems/acre2@090abc6