Multilingual logic

[rathorevaibhav]

Questions

In the following JS code:

1. Where do you see a violation of the Single Responsibility Principle?
2. What other SOLID principles do you see not being followed?
3. Can you share a better, more efficient, more developer-friendly version of the code below?

export async function getAllLanguages() {
    const response = await ApiInstance.get('/languages');
    const data = await response.data;
    const languagesData = data['languages'];

    const languages = [];
    for (const index in languagesData) {
        languages.push({
            id: languagesData[index],
            text: languagesData[index],
            value: index,
            checked: false
        });
    }

    return languages;
}

[belwalshubham]

@rathorevaibhav
I think we can optimize the above code to something like that which make a different function for different responsibility.

// getting the language data
async function fetchLanguages() {
  const response = await ApiInstance.get('/languages')
  return response.data.languages
}

function ConvertLanguage(languagesData) {
  //here the code for transform the language data into the format
}

// and then from below one we call the both fetchLanguages and ConvertLanguages

export function getAllLanguages() {
  const languagesData = fetchLanguages()
  const languages = ConvertLanguage(languagesData)
  return languages
}