Contact logic - all in one!

[rathorevaibhav]

Questions

In the following PHP/Laravel code:

1. Where do you see a violation of the Single Responsibility Principle?
2. What other SOLID principles do you see not being followed?
3. Can you share a better, more efficient, more developer-friendly version of the code below?

public function storeContact(Request $request)
{
    // validating the request data
    $validated = $request->validate([
        'name' => 'required|string',
        'email' => 'required|string|email',
        'phone' => 'required|string',
        'city' => 'required|string',
        'message' => 'required|string',
    ]);
    
    // creating an entry in database
    Contact::create([
        'name' => $validated['name'],
        'email' => $validated['email'],
        'phone' => $validated['phone'],
        'city' => $validated['city'],
        'message' => $validated['message'],
    ]);
    
    // Sending mail
    Mail::to('dlf-foundation@dlf.in')->send(new ContactMail($validated));

    // Redirecting the user to another page with a success message
    return redirect()->route('contact.index')->with([
        'success' => 'Submitted successfully!'
    ]);
}

[rohit123-rawat]

1. we can move validation rules in request file
2. can use validated variable to create contact.
3. also we can make separate mail function

public function storeContact(ContactRequest $request)
{
    $validated = $request->validate();

    Contact::create($validated);

    Mail::to('dlf-foundation@dlf.in')->send(new ContactMail($validated));

    return redirect()->route('contact.index')->with([
        'success' => 'Submitted successfully!'
    ]);
}

[deepankar-sajwan]

The storeContact method appears to handle multiple actions. It validates the input, creates a new contact record, sends an email, and redirects the user. It would be better to separate these responsibilities, into different classes or methods to adhere more closely to the SRP.