Preprocessors broken

[TBar09]

So when using preprocessors (#if #end), there is a "bug" where setting a custom preprocessor to false or 0

#if THIS_IS_FALSE //doesn't matter if this is set to `false` or `0`, it will still run
trace("hello");
#end

This will trace the message

I kinda figured that it would only check if the preprocessor exists and not check it's property (especially since doing things like #if(hxvlc >= "1.9.2") or version checking doesn't work altogether) So I kinda just thought it would be nice if the parser would check it's property and could have the ability to check version like above.

[NeeEoo]

@Redar13 i think your pr broke something

[Redar13]

I don't think so, the problem here is that the check is only for comparing the variable to null, and also not all operators are there.

hscript-improved/hscript/Parser.hx

Lines 1941 to 1965 in 49c90e6

	function evalPreproCond( e : Expr ) {
	switch( expr(e) ) {
	case EIdent(id):
	return preprocValue(id) != null;
	case EField(e2, f):
	switch(expr(e2)) {
	case EIdent(id):
	return preprocValue(id + "." + f) != null;
	default:
	error(EInvalidPreprocessor("Can't eval " + expr(e).getName() + " with " + expr(e2).getName()), readPos, readPos);
	return false;
	}
	case EUnop("!", _, e):
	return !evalPreproCond(e);
	case EParent(e):
	return evalPreproCond(e);
	case EBinop("&&", e1, e2):
	return evalPreproCond(e1) && evalPreproCond(e2);
	case EBinop("||", e1, e2):
	return evalPreproCond(e1) || evalPreproCond(e2);
	default:
	error(EInvalidPreprocessor("Can't eval " + expr(e).getName()), readPos, readPos);
	return false;
	}
	}

Can I make a pull request for that?

[NeeEoo]

i mean here you arent checking the code maybe thats something? feel free to test around and make a pr

[Redar13]

i mean here you arent checking the code maybe thats something? feel free to test around and make a pr

Here I just added a check when Eof occurs, so it should hardly cause problems in the main content.

[Redar13]

I also did a test, and my theory was confirmed.

	var preprocesorValues = HScript.parser.preprocesorValues;

	preprocesorValues.set("THIS_IS_FALSE_NUMBER", 0);
	preprocesorValues.set("THIS_IS_TRUE_NUMBER", 1);
	preprocesorValues.set("THIS_IS_FALSE", false);
	preprocesorValues.set("THIS_IS_TRUE", true);
	preprocesorValues.set("THIS_IS_NULL", null);

	trace("");
	trace("THIS_IS_FALSE_NUMBER: " + preprocesorValues.get("THIS_IS_FALSE_NUMBER"));
	trace("THIS_IS_TRUE_NUMBER: " + preprocesorValues.get("THIS_IS_TRUE_NUMBER"));
	trace("THIS_IS_FALSE: " + preprocesorValues.get("THIS_IS_FALSE"));
	trace("THIS_IS_TRUE: " + preprocesorValues.get("THIS_IS_TRUE"));
	trace("THIS_IS_NULL: " + preprocesorValues.get("THIS_IS_NULL"));
	trace("");
	trace("");
	trace("");
	trace("");
	#if THIS_IS_FALSE_NUMBER
	trace("THIS_IS_FALSE_NUMBER");
	#end
	#if THIS_IS_TRUE_NUMBER
	trace("THIS_IS_TRUE_NUMBER");
	#end
	#if THIS_IS_FALSE
	trace("THIS_IS_FALSE");
	#end
	#if THIS_IS_TRUE
	trace("THIS_IS_TRUE");
	#end
	#if THIS_IS_NULL
	trace("THIS_IS_NULL");
	#end
	trace("");
	trace("");
	trace("");
	trace("");
	trace("");
	trace("");

[NeeEoo]

ohhh wait i see now that this is a different issue thought this was saying false #ifs at the end of the file always ran

[NeeEoo]

But yea feel free to make a pr to fix it

[Redar13]

Alr, I think I'll do it tomorrow.