Encapsulate the "bottom button" use case

[piercifani]

This type of ViewControllers are pretty common in modern iOS applications, yet they're always tricky to build and we have to resort to hacks like this:

Create a new abstraction using UIViewController containment and additionalSafeAreaInsets to fix this common scenario.

[deceroainfinito]

I would rid off viewDidLayoutSubviews()method, create

private func setupSaveButton() {
  saveButton.addTarget(self, action: #selector(onSave), for: .touchDown)
  additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: saveButton.bounds.height, right: 0)
}

and call it inside the GifCreateViewController's setup()method.

Were you thinking in another type of abstraction?

[piercifani]

Interesting: additionalSafeAreaInsets IS the right API to approach this, but will saveButton.bounds.height always be the right value when this is called?

And since we're building an abstraction, why not treat the bottom button the same way UINavigationController treats it's navigationBar?

[deceroainfinito]

I guess you should need to create a view collection in order to check them up and calculate the proper inset's height value...