-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Currently, some of the modules depend on Javascript libraries grabbed from Node.js repositories.
Currently, such libraries aren't "shipped" with the application, and are to be placed, I guess manually, into .spacedoc/js/require. That is, going onto that directory, and running npm install ${package name here} .. The application itself has no way to install these dependencies on its own, which may or may not be a good thing.
The required dependencies aren't well documented anywhere, and are currently hardcoded into the WavedromJS and VizJS code.
The dependencies are the following, how-ever irrelevant it is:
- VizJS
viz.jsviz.js/full.render.js
- WavedromJS
json5onml
Something should be done about this, to make it easier to run for other people, and so one doesn't have to have a .spacedoc directory somewhere with the exact same libraries all over. Those libraries may also use different version than what spacedoc expects, and as such it would concievably become quite a bit of a pain.
So, JS packages should then be packaged into the application jars/images somehow.
- Figure out some way of packaging these JS libraries in
- Make sure to automate this with maven/whatever relevant JS tooling:
- Maven builds should be able to download JS dependency files when those are not present
- Maven builds should then package those dependencies into the final jars/images
- Make sure to also package all license-mandated baggage, see Check and obey licenses of all dependencies #10 for more.