Skip to content

Commit a8bfc06

Browse files
committed
Remove unused maxResults parameter from search endpoint
Self-review finding: the maxResults query parameter was accepted by the controller but not meaningfully forwarded (service uses internal caps). Removed to avoid misleading API surface.
1 parent b6e13eb commit a8bfc06

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

backend/src/Taskdeck.Api/Controllers/SearchController.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@ public SearchController(ISearchService searchService, IUserContext userContext)
2121
[HttpGet]
2222
public async Task<IActionResult> Search(
2323
[FromQuery] string? q,
24-
[FromQuery] int maxResults = 20,
2524
CancellationToken cancellationToken = default)
2625
{
2726
if (!TryGetCurrentUserId(out var userId, out var errorResult))
2827
return errorResult!;
2928

30-
var result = await _searchService.SearchAsync(userId, q ?? string.Empty, maxResults, cancellationToken);
29+
var result = await _searchService.SearchAsync(userId, q ?? string.Empty, cancellationToken: cancellationToken);
3130
return result.IsSuccess ? Ok(result.Value) : result.ToErrorActionResult();
3231
}
3332
}

frontend/taskdeck-web/src/api/searchApi.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ export interface GlobalSearchResult {
2323
}
2424

2525
export const searchApi = {
26-
async search(query: string, maxResults = 20): Promise<GlobalSearchResult> {
26+
async search(query: string): Promise<GlobalSearchResult> {
2727
const params = new URLSearchParams()
2828
params.append('q', query)
29-
if (maxResults !== 20) params.append('maxResults', String(maxResults))
3029
const { data } = await http.get<GlobalSearchResult>(`/search?${params}`)
3130
return data
3231
},

0 commit comments

Comments
 (0)