Skip to content

Commit 67d9ad2

Browse files
committed
docs: address bot review findings on PR #764
- AGENTS.md: add $LASTEXITCODE fail-fast checks to PowerShell command chain (Gemini + Copilot finding) - TESTING_GUIDE.md: clarify telemetry taxonomy is "documented" not "delivered" (spec exists, instrumentation not shipped); fix proposal.dismissed → proposal.rejected (matches actual taxonomy) - STATUS.md: annotate stale frontend unit count (1491) with pointer to latest estimate (1592) in TESTING_GUIDE.md
1 parent cb9d95d commit 67d9ad2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ Its scope applies to the entire repo unless overridden by more specific `AGENTS.
100100
- Backend API (local): from `backend/src/Taskdeck.Api`, run `dotnet run`.
101101
- Frontend dev server: from `frontend/taskdeck-web`, run `npm install` once, then `npm run dev`.
102102
- Frontend checks (required when frontend touched): from `frontend/taskdeck-web`,
103-
`npm run typecheck ; npm run build ; npx vitest --run` (use `;` not `&&` in PowerShell).
103+
`npm run typecheck; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }; npm run build; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }; npx vitest --run` (PowerShell fail-fast; do not use `&&`).
104104

105105
## Coding Style & Naming
106106
- Backend: C# conventions, 4-space indentation, PascalCase for classes and public members,

docs/STATUS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,7 @@ Commands:
781781
- `cd frontend/taskdeck-web && npm run build`
782782

783783
Result:
784-
- Frontend unit: 1491/1491 passing (134 test files)
784+
- Frontend unit: 1491/1491 passing (134 test files)**stale**: post-wave count is 1592/1592 (~125 files); see `docs/TESTING_GUIDE.md` for latest estimates
785785
- Typecheck: passing
786786
- Production build: passing
787787

docs/TESTING_GUIDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ High-signal additions and delivered guardrails:
5151

5252
Telemetry and release-gate follow-through from the expanded blueprint:
5353

54-
- product telemetry/event taxonomy delivered in `#341`/`#741` — see `docs/product/TELEMETRY_TAXONOMY.md`; reuses `#77` as baseline; `#328` provides the delivered first-run guardrail
55-
- keep event names privacy-safe and product-shaped using the canonical `noun.verb` format from `docs/product/TELEMETRY_TAXONOMY.md` (for example `capture.modal_opened`, `capture.submitted`, `proposal.approved`, `proposal.dismissed`, `card.created`, `board.loaded`, `auth_session.started`, `agent_run.completed`, `agent_run.failed`)
54+
- product telemetry/event taxonomy documented in `#341`/`#741` — see `docs/product/TELEMETRY_TAXONOMY.md` (taxonomy spec, not shipped instrumentation); reuses `#77` as baseline; `#328` provides the delivered first-run guardrail
55+
- keep event names privacy-safe and product-shaped using the canonical `noun.verb` format from `docs/product/TELEMETRY_TAXONOMY.md` (for example `capture.modal_opened`, `capture.submitted`, `proposal.approved`, `proposal.rejected`, `card.created`, `board.loaded`, `auth_session.started`, `agent_run.completed`, `agent_run.failed`)
5656
- treat launch framing as evidence gates, not marketing labels:
5757
- `R1` novice-first beta -> coherent `Home -> capture -> review -> execute -> board` path
5858
- `R2` agent foundation alpha -> inspectable runs, policies, and bounded templates

0 commit comments

Comments
 (0)