fix vulnerabilities from SQ

Author: Yann Prono

src/main/java/io/chocorean/authmod/authentication/datasource/DatabaseSourceStrategy.java

@@ -59,7 +59,7 @@ public boolean exist(IPlayer player) {
         try {
             return this.playersDAO.findFirst(player) != null;
         } catch (SQLException e) {
-            e.printStackTrace();
+            LOGGER.catching(Level.ERROR, e);
         }
         return false;
     }

src/main/java/io/chocorean/authmod/authentication/datasource/FileDataSourceStrategy.java

@@ -3,6 +3,7 @@
 import io.chocorean.authmod.model.IPlayer;
 import io.chocorean.authmod.model.Player;
 import net.minecraftforge.fml.common.FMLLog;
+import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.Logger;
 
 import java.io.*;
@@ -25,26 +26,28 @@ public FileDataSourceStrategy(File authFile) {
 
     private void readFile() {
         this.players.clear();
+        boolean created;
         try {
-            this.authFile.createNewFile();
-        } catch (IOException e) { LOGGER.catching(e); }
-        try(BufferedReader bf = new BufferedReader(new FileReader(this.authFile))) {
-            String line;
-            while((line = bf.readLine()) != null && line.trim().length() > 0) {
-                if(!line.startsWith("#")) {
-                    String[] parts = line.trim().split(SEPARATOR);
-                    IPlayer p = new Player();
-                    p.setEmail(parts[0].trim());
-                    p.setUsername(parts[1].trim());
-                    p.setPassword(parts[2].trim());
-                    p.setBan(Boolean.parseBoolean(parts[3].trim()));
-                    this.players.put(p.getEmail(), p);
+            created = this.authFile.createNewFile();
+            if(created) {
+                try(BufferedReader bf = new BufferedReader(new FileReader(this.authFile))) {
+                    String line;
+                    while((line = bf.readLine()) != null && line.trim().length() > 0) {
+                        if(!line.startsWith("#")) {
+                            String[] parts = line.trim().split(SEPARATOR);
+                            IPlayer p = new Player();
+                            p.setEmail(parts[0].trim());
+                            p.setUsername(parts[1].trim());
+                            p.setPassword(parts[2].trim());
+                            p.setBan(Boolean.parseBoolean(parts[3].trim()));
+                            this.players.put(p.getEmail(), p);
+                        }
+                    }
+                    this.lastModification = this.authFile.lastModified();
                 }
             }
-            this.lastModification = this.authFile.lastModified();
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+        } catch (IOException e) { LOGGER.catching(e); }
+
     }
 
     private void reloadFile() {

src/main/java/io/chocorean/authmod/command/LoginCommand.java

@@ -74,10 +74,8 @@ public void execute(MinecraftServer server, ICommandSender sender, String[] args
                         );
                     }
                 } catch (Exception e) {
-                    e.printStackTrace();
                     LOGGER.error(e.getMessage());
                     ((EntityPlayerMP)sender).connection.sendPacket(new SPacketChat(new TextComponentString(e.getMessage())));
-                    loggedPlayer = null;
                 }
             }
             else {