Skip to content
This repository was archived by the owner on Oct 9, 2024. It is now read-only.
This repository was archived by the owner on Oct 9, 2024. It is now read-only.

Formatting is wrong, action still passes #11

@RomeoAva

Description

@RomeoAva

Hi, I am a new user to Ruff (transitioning from Black).
I am trying to setup this action on my repo to have the same functionalities I had with Black.

For example:

app = FastAPI(
    title="API",
    description="API",
    version="0.0.1",terms_of_service="https://example.com/",
)

With this code block, the formatting is wrong, it should be

app = FastAPI(
    title="API",
    description="API",
    version="0.0.1",
    terms_of_service="https://example.com/"
)

And this is indeed fixed once I do the command ruff format app/main.py.

But when opening a pull request, ruff-action doesnt seem to mind that formatting mistake. How could I make it more strict in this sense to enforce the code formatting rules?

Here is my action:

name: Ruff
on: [push, pull_request]
jobs:
  ruff:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: chartboost/ruff-action@v1

Thank you for your help

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions