New HTTP endpoint to add trusted peer

[nflaig]

see discord discussion

[cjustinobi]

@nflaig Can I handle this? If I got green light, should I refactor /eth/v1/lodestar/connect_peer to use ENR or I should create a fresh endpoint?

[nflaig]

@nflaig Can I handle this? If I got green light, should I refactor /eth/v1/lodestar/connect_peer to use ENR or I should create a fresh endpoint?

I would say just update the current endpoint, I don't think it's great how it works right now and I don't know anyone that's using it, I am not even sure it works properly

so this is a good first step, setting a peer as trusted in peer store might be more involved, I am not sure myself but we have others in the team which are more familiar with networking / peer management that can help here

[nflaig]

this should be easy to implement once we have #8831 merged

[catwith1hat]

I was curious on whether Claude would manage to implement this properly and for the most part the referenced commit above looks okay, except that it reaches into libp2p internals to get the job done, which I am not super comfortable with. Maybe libp2p should be extended to offer an API to add/remove peers dynamically, so the commit can do without reaching into "this.direct" in the subclass.

[nflaig]

I will let @lodekeeper take a look

[nflaig]

#8853 isn't too bad, similar to what you have @catwith1hat