Modded entities hitting water cause client to crash.

[mutantfrogs]

I am playing with Supplementaries (1.20-2.8.17) on a multiplayer server (Fabric 1.20.1), and whenever a bomb hits the water, it causes everyone's client to crash if they have Particular (1.1.1) installed. When particular is disabled, entity hitting doesn't cause a crash.

[YnwLNE]

Can confirm, it's usually larger mobs/animals that trigger the crash.

[Topodic]

Experiencing this with Supplementaries bombs as well. Disabling waterSplash in Particular's config seems to fix it in the meantime without having to disable the mod entirely, thankfully.

[Fyoncle]

any newsss?

[ThexXTURBOXx]

I've got a bug report about this over at ThexXTURBOXx/Balkons-WeaponMod-Legacy#67 and it can be reproduced very easily and consistently.
In our case, the culprit is clear:

particular/src/main/java/com/chailotl/particular/mixin/InjectEntity.java

Line 90 in 9536d73

getWorld().addParticle(Particles.WATER_SPLASH_EMITTER, getX(), baseY + prevState.getHeight(), getZ(), dimensions.width, Collections.max(velocities), 0.0);

The Collections#max call must have some safeguard against velocities being empty.
Otherwise, such crashes can occur pretty easily.
So, the real problem is that mods tend to override the tick function - this causes onSetVelocity to never get called and hence velocities remains empty (and thus, a max call crashes).

[lihaan]

Also facing this issue when firing cannonballs into the water (Small Ships mod)

[ThexXTURBOXx]

@lihaan The bugfix is already there - we just need to wait for #41 to get merged. Alternatively, build the mod from source yourself

[ThexXTURBOXx]

I noticed that this project is GPL licensed. So, I can upload my builds without any problems by stating the following:

• The builds in that zip below are licensed under the exact same conditions as Chailotl's official particular mod
• They contain a copy of the GPL license

There is a 1.21 and a 1.20.x build in this zip file: hotfixes.zip
Choose whatever one you need!