Skip to content

Inconsistent Update() Calls in Group Methods #407

@thehabes

Description

@thehabes

Files: classes/Group/Group.js (multiple methods)

Issue: Some methods call update() after modifying data, others don't. Inconsistent behavior.

  • setMemberRoles() - calls update()
  • addMemberRoles() - does NOT call update()
  • removeMemberRoles() - calls update()
  • removeMember() - does NOT call update()

Impact: Data changes not persisted to database unless caller remembers to call update(). Leads to data loss.

Fix: Either all methods should call update(), or none should (documented pattern).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions