A non-existent Mapbox API key causes an error (no DO analysis) in onpremises

[antoniocarlon]

The DO analysis doesn't show in the UI when there's no Mapbox API key set (tested using an onpremises installation). The error is:

2018-03-08 11:47:40 GMT geocoder_api db_dataservices [unknown] ERROR:  spiexceptions.ExternalRoutineException: cartodb_services.metrics.config.ConfigException: Mapbox config is not set up
2018-03-08 11:47:40 GMT geocoder_api db_dataservices [unknown] CONTEXT:  Traceback (most recent call last):
          PL/Python function "cdb_service_quota_info", line 25, in <module>
            plpy.execute("SELECT cdb_dataservices_server._get_geocoder_config({0}, {1})".format(plpy.quote_nullable(username), plpy.quote_nullable(orgname)))
        PL/Python function "cdb_service_quota_info"
2018-03-08 11:47:40 GMT geocoder_api db_dataservices [unknown] STATEMENT:  SELECT * FROM cdb_dataservices_server.cdb_service_quota_info ($1::text, $2::text)

[jvillarf]

It could be related to a similar issue we faced with mapzen config in the past: https://github.com/CartoDB/onpremises/issues/372

• Dataservices geocoder fallback issues for namedplaces #371

[ethervoid]

Duped #374

Is not a bug and shouldn't be tackle checking the api key. We need to revamp the configuration and make the services "plugables"