Skip to content

Bug: /error endpoint is accessible in ui even with toggle off #2956

@danoswaltCL

Description

@danoswaltCL

Today after deployment I happened to notice in new relic this call to /error endpoint happened, which shouldn't be really possible because we wrapped a toggle around the tab to hide it after it was discovered to cause lots of performance problems, as it selects all and it's a million rows of garbage, way too much data.

Image

I'm not sure how this hasn't come up before now, but the experiment_error database shouldn't be accessible from the UI when the error display toggle in the frontend is false.

While the tab is hidden from the ui, the /error endpoint does still actually get called (!) when hitting the audit logs page via a call in the onNgInit function.

That means that this has been able to be called from the ui this whole time. It doesn't seem to bring the database any grief these days, but it's still no good.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done for Release

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions