-
Notifications
You must be signed in to change notification settings - Fork 0
chore(): bad code #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CarloGauss33
wants to merge
1
commit into
main
Choose a base branch
from
chore/bad-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| const https = require('https'); | ||
|
|
||
| const data = JSON.stringify({ | ||
| todo: 'Buy the milk' | ||
| }) | ||
|
|
||
| const options = { | ||
| hostname: 'buda.com', | ||
| port: 443, | ||
| path: '/todos', | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'Content-Length': data.length, | ||
| 'Authorization': 'Bearer your_api_key' | ||
| } | ||
| } | ||
|
|
||
| const req = https.request(options, (res) => { | ||
| console.log(`statusCode: ${res.statusCode}`) | ||
|
|
||
| res.on('data', (d) => { | ||
| process.stdout.write(d) | ||
| }) | ||
| }) | ||
|
|
||
| req.on('error', (error) => { | ||
| console.error(error) | ||
| }) | ||
|
|
||
| req.write(data) | ||
| req.end() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Handling
Consider adding more robust error handling. Current implementation logs the error to the console but doesn't handle the error beyond logging.
Content-Length Header
The
Content-Lengthheader is automatically set by thehttps.request()method when writing data to the request object so you may not need to set it manually unless for a specific reason. If setting it manually, ensure that it matches the byte length and not just the string length, which can be different for multi-byte characters.Promisifying the Request
Consider using or creating a promise-based version of the HTTP request to better fit with modern async handling patterns such as async/await.
Response Handling
Make sure to handle the full response data, as the
dataevent could be called multiple times if the response is large. You might want to concatenate the data chunks until the 'end' event.Miscellaneous