From 4ed44a39f86c5ba4c54e8556be05f37e3beb6087 Mon Sep 17 00:00:00 2001 From: Wander03 Date: Mon, 13 May 2024 10:52:35 -0700 Subject: [PATCH 1/3] fixed compliments: default follow_up --> FALSE --- R/compliments.R | 2 +- tests/testthat/testthat-problems.rds | Bin 0 -> 2013 bytes 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 tests/testthat/testthat-problems.rds diff --git a/R/compliments.R b/R/compliments.R index e0066f2..89b48be 100644 --- a/R/compliments.R +++ b/R/compliments.R @@ -7,7 +7,7 @@ #' @return A compliment string #' #' @export -really_pretty <- function(name, follow_up = TRUE) { +really_pretty <- function(name, follow_up = FALSE) { compliment <- glue::glue("You're, like, really pretty, {name}.") diff --git a/tests/testthat/testthat-problems.rds b/tests/testthat/testthat-problems.rds new file mode 100644 index 0000000000000000000000000000000000000000..c6d3b7750acf79a16b7110cb07822d8396b74d4f GIT binary patch literal 2013 zcmV<32O{_%iwFP!000002JKqSa}-q&pX@GyYz$d~DG4#=u>_J7`5>iyR3u6W!Aey~ zfPjK1%eebC88W-G&P+&FNELG6V5ueLNl^|~DHdE5MLGDvf%2j#2c=3579Obb>>r@M zx7)qjGkF8ViU*Zc_5No1_qyNf?wOw1ec2z?G%ch>!eK2G7Khq$Ar+bymRKnyRydDn zRRUi>oXIC_?o65PVV1RA#$TM$P3BtcaMH4Eo^+AziuQE(u#DkkbT>J{o#@QLp67d6 z{D3vpYV!_e8k6GF=DKO-S6h?|w)`(Rt5wciF7_c3V+u>YD zBt)WE?AXb)VRCU8(Tab+3;6?rZ-QeGk7;N+A)5vlMTsMI-E{zh>sx4j&KLO!STlSf8% zmd<-hq}NRgW2HJv51z@};?gGG?z3rUjL+oc%!O;Bt>mD?w8j^%30o;ve^r^p5!KXS26a?1h+X$87axIaqcq1eUgn??5L4-^>Mz+ zpNloVT$C5o7DvDTWHL72AsKAia3@4C>9hzc>oPrcM7TDNaz&O#7bHtb%e3tDlsP9& zefN^4j`9jwAB&^2g-zewn=3q+P5SQI#Z%eItTmktxE(7EXGgI?M2p?9ApTKRu8|SN z(K9(Q$5Ki3|NO?Av5ED+`S0$esXKUghj0nIM#qNsCtaMfa7y|^U=La%dskM^a9>Py z@=EDUTA7?F)|GXgu03jR_adGdYtqIHPmS{55kN=~;OzFl|qVtWo>CWEC^6|tfX z&clFFAGQ^erD=l-d-*pCw#ZilHiQ3&R_yPUpl3epkd+CrNB@-q#{eJJ%Jpy5iqG3cKE(RVu`LRF^xs7IM*vro{74-GeG5V9 zU%nnR2iT*3rkKBl@GXk?DZdu-OJ7ege=@#xLOMZTOAzCi*J!W89{qO`J_fi#E7z|} z$a>H>5X9@hJHQ_OuP1yXU>ouOn2?QH`LzoX^SdFy9{q1r#Me&vUdZ1P@QEm8R>%{; z<9&%d+DmQ_^dW+{zJATyUyw)pK{&?VAd&X3oiI-7qXe;jBSKCq?9u-y;ZgAZkk{`n zA$vgIL=fw@JHQ_O?;(6MLF`{o3wc#5-rHfom{zXu0U-xLUk6D0*Rw(r3VWRYAmQr) zM@W3n2|1+T(f*LaKjjm!e(bTenzw(+xAipWu@}?+C7+?T!XEvn2_FN5`=?O?M>x7V#pl>IL`F%OS z9{rzG#7FzrDac-)ZtbD*ySr2XpyAr}<(IR81q*8`4{_&yYJUcsaNd4+$Sg?yv1NBk}cDK(~@0*8fu>R~7c?{}SOF0crpGOvq)>uOW!_|2)7R z{a+@0D_}SHm*-y)zK5XX<-6CHgntxp3t8V+Lau5i{~Fo+ zBcl~>SA6B1_W!=%T9Z7BzX(i&_QA0OJGYGvCwA-`8Q42CI+7UZA09@ht!=Gv z7~wNH8^3Ii?cI|Y7#$hgTN>A)8W(OohU&`VEO1smJh)?TqJL~`=&6x=@lQ#5JTI>c z6KK0?T+s2~n9>_kKw|xa?z*UO>#Vv!O3V9~#QjU+{w1;Cfkwgg*uHJJvccWt?07Yqy)UGL_G}Ozpt~4BKIbfMPO8)y3Y@)S*01o7yn8L{=5D+#SRs2C zY;SHJ^^KO}35q#d-l+QT7kJ$~HWL@D@{cdve&au0dVjE0rF`IszLIfiBlF*T-4q@G zOa9cnTZ(iqkM0bX2I6LBHT+9O(#m1;B>!dMw<>)N5<_gBF8eNgX_DWwSYW$n7a*GtdVpZazgvt@E#J2#jaOFi%ipbS%H<7mGMk{24XHy Date: Mon, 13 May 2024 10:53:15 -0700 Subject: [PATCH 2/3] updated function desc --- R/compliments.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/compliments.R b/R/compliments.R index 89b48be..e37d6ca 100644 --- a/R/compliments.R +++ b/R/compliments.R @@ -2,7 +2,7 @@ #' #' @param name The person's name #' @param follow_up Should the function follow up with questions? -#' Defaults to `TRUE`. +#' Defaults to `FALSE`. #' #' @return A compliment string #' From 078e2389b7f2142eb211610b521bf6388319da6e Mon Sep 17 00:00:00 2001 From: Wander03 Date: Mon, 13 May 2024 10:54:49 -0700 Subject: [PATCH 3/3] fixed really_pretty: removed , from before name --- R/compliments.R | 2 +- tests/testthat/testthat-problems.rds | Bin 2013 -> 0 bytes 2 files changed, 1 insertion(+), 1 deletion(-) delete mode 100644 tests/testthat/testthat-problems.rds diff --git a/R/compliments.R b/R/compliments.R index e37d6ca..e81f48e 100644 --- a/R/compliments.R +++ b/R/compliments.R @@ -9,7 +9,7 @@ #' @export really_pretty <- function(name, follow_up = FALSE) { - compliment <- glue::glue("You're, like, really pretty, {name}.") + compliment <- glue::glue("You're, like, really pretty {name}.") if (follow_up) { compliment <- paste(compliment, diff --git a/tests/testthat/testthat-problems.rds b/tests/testthat/testthat-problems.rds deleted file mode 100644 index c6d3b7750acf79a16b7110cb07822d8396b74d4f..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2013 zcmV<32O{_%iwFP!000002JKqSa}-q&pX@GyYz$d~DG4#=u>_J7`5>iyR3u6W!Aey~ zfPjK1%eebC88W-G&P+&FNELG6V5ueLNl^|~DHdE5MLGDvf%2j#2c=3579Obb>>r@M zx7)qjGkF8ViU*Zc_5No1_qyNf?wOw1ec2z?G%ch>!eK2G7Khq$Ar+bymRKnyRydDn zRRUi>oXIC_?o65PVV1RA#$TM$P3BtcaMH4Eo^+AziuQE(u#DkkbT>J{o#@QLp67d6 z{D3vpYV!_e8k6GF=DKO-S6h?|w)`(Rt5wciF7_c3V+u>YD zBt)WE?AXb)VRCU8(Tab+3;6?rZ-QeGk7;N+A)5vlMTsMI-E{zh>sx4j&KLO!STlSf8% zmd<-hq}NRgW2HJv51z@};?gGG?z3rUjL+oc%!O;Bt>mD?w8j^%30o;ve^r^p5!KXS26a?1h+X$87axIaqcq1eUgn??5L4-^>Mz+ zpNloVT$C5o7DvDTWHL72AsKAia3@4C>9hzc>oPrcM7TDNaz&O#7bHtb%e3tDlsP9& zefN^4j`9jwAB&^2g-zewn=3q+P5SQI#Z%eItTmktxE(7EXGgI?M2p?9ApTKRu8|SN z(K9(Q$5Ki3|NO?Av5ED+`S0$esXKUghj0nIM#qNsCtaMfa7y|^U=La%dskM^a9>Py z@=EDUTA7?F)|GXgu03jR_adGdYtqIHPmS{55kN=~;OzFl|qVtWo>CWEC^6|tfX z&clFFAGQ^erD=l-d-*pCw#ZilHiQ3&R_yPUpl3epkd+CrNB@-q#{eJJ%Jpy5iqG3cKE(RVu`LRF^xs7IM*vro{74-GeG5V9 zU%nnR2iT*3rkKBl@GXk?DZdu-OJ7ege=@#xLOMZTOAzCi*J!W89{qO`J_fi#E7z|} z$a>H>5X9@hJHQ_OuP1yXU>ouOn2?QH`LzoX^SdFy9{q1r#Me&vUdZ1P@QEm8R>%{; z<9&%d+DmQ_^dW+{zJATyUyw)pK{&?VAd&X3oiI-7qXe;jBSKCq?9u-y;ZgAZkk{`n zA$vgIL=fw@JHQ_O?;(6MLF`{o3wc#5-rHfom{zXu0U-xLUk6D0*Rw(r3VWRYAmQr) zM@W3n2|1+T(f*LaKjjm!e(bTenzw(+xAipWu@}?+C7+?T!XEvn2_FN5`=?O?M>x7V#pl>IL`F%OS z9{rzG#7FzrDac-)ZtbD*ySr2XpyAr}<(IR81q*8`4{_&yYJUcsaNd4+$Sg?yv1NBk}cDK(~@0*8fu>R~7c?{}SOF0crpGOvq)>uOW!_|2)7R z{a+@0D_}SHm*-y)zK5XX<-6CHgntxp3t8V+Lau5i{~Fo+ zBcl~>SA6B1_W!=%T9Z7BzX(i&_QA0OJGYGvCwA-`8Q42CI+7UZA09@ht!=Gv z7~wNH8^3Ii?cI|Y7#$hgTN>A)8W(OohU&`VEO1smJh)?TqJL~`=&6x=@lQ#5JTI>c z6KK0?T+s2~n9>_kKw|xa?z*UO>#Vv!O3V9~#QjU+{w1;Cfkwgg*uHJJvccWt?07Yqy)UGL_G}Ozpt~4BKIbfMPO8)y3Y@)S*01o7yn8L{=5D+#SRs2C zY;SHJ^^KO}35q#d-l+QT7kJ$~HWL@D@{cdve&au0dVjE0rF`IszLIfiBlF*T-4q@G zOa9cnTZ(iqkM0bX2I6LBHT+9O(#m1;B>!dMw<>)N5<_gBF8eNgX_DWwSYW$n7a*GtdVpZazgvt@E#J2#jaOFi%ipbS%H<7mGMk{24XHy