Relogin issue?

[HarelM]

We have seen the following issue in our server logs - a failure to relogin basically (according to the stack trace).

• Mapeak silently fails to upload images IsraelHikingMap/Site#2300

Here's the stack trace:

---> WikiClientLibrary.OperationFailedException: Failed: Unable to continue login. Your session most likely timed out.
--
  | at WikiClientLibrary.Sites.WikiSite.LoginAsync(String userName, String password, String domain, CancellationToken cancellationToken)
  | at IsraelHiking.DataAccess.LoginAgainAccountAssertionFailureHandler.Login(WikiSite site) in /net/IsraelHiking.DataAccess/WikimediaCommonGateway.cs:line 32   at IsraelHiking.DataAccess.LoginAgainAccountAssertionFailureHandler.Login(WikiSite site) in /net/IsraelHiking.DataAccess/WikimediaCommonGateway.cs:line 32
  | at WikiClientLibrary.Sites.WikiSite.Relogin()   at WikiClientLibrary.Sites.WikiSite.Relogin()
  | at WikiClientLibrary.Sites.WikiSite.InvokeMediaWikiApiAsync[T](WikiRequestMessage message, IWikiResponseMessageParser`1 responseParser, Boolean suppressAccountAssertion, CancellationToken cancellationToken)   at WikiClientLibrary.Sites.WikiSite.InvokeMediaWikiApiAsync[T](WikiRequestMessage message, IWikiResponseMessageParser`1 responseParser, Boolean suppressAccountAssertion, CancellationToken cancellationToken)
  | at WikiClientLibrary.RequestHelper.RefreshPagesAsync(IEnumerable`1 pages, IWikiPageQueryProvider options, CancellationToken cancellationToken)   at WikiClientLibrary.RequestHelper.RefreshPagesAsync(IEnumerable`1 pages, IWikiPageQueryProvider options, CancellationToken cancellationToken)

The code that we are using is the following basically (for relogin):

internal class LoginAgainAccountAssertionFailureHandler : IAccountAssertionFailureHandler
{

    private readonly NonPublicConfigurationData _options;

    public LoginAgainAccountAssertionFailureHandler(NonPublicConfigurationData options)
    {
        _options = options;
    }

    public async Task<bool> Login(WikiSite site)
    {
        await site.LoginAsync(_options.WikiMediaUserName, _options.WikiMediaPassword);
        return true;
    }
}

And in the gateway class (the service which we initialize when the server code starts):

public async Task Initialize()
    {
        var wikiClient = new WikiClient
        {
            ClientUserAgent = Branding.USER_AGENT,
            Timeout = new TimeSpan(0, 5, 0) // allow large images upload
        };

        _site = new WikiSite(wikiClient, new SiteOptions(BASE_API_ADDRESS));
        await _site.Initialization;
        await _site.LoginAsync(_options.WikiMediaUserName, _options.WikiMediaPassword);
        _site.AccountAssertionFailureHandler = new LoginAgainAccountAssertionFailureHandler(_options);
        _logger.LogInformation("Finished initializing Wikimedia common service");
    }

The above issue is seen when we try to invoke upload image call:

public async Task<string> UploadImage(string fileName, string description, string author, Stream contentStream, Coordinate location)
    {
        _logger.LogInformation($"Upload an image to wikimedia common. File name: {fileName}, Location: {location.Y}, {location.X}");
        var wikiFileName = GetNonExistingFilePageName(fileName);
        var comment = CreateWikipediaComment(location, description, author);
        await _site.GetTokenAsync("edit", true);
        var results = await _site.UploadAsync(wikiFileName, new StreamUploadSource(contentStream), comment, true).ConfigureAwait(false);
        if (results.ResultCode != UploadResultCode.Success)
        {
            throw new Exception("Unable to upload the file\n" + string.Join("\n", results.Warnings.Select(kvp => kvp.Key + ": " + kvp.Value)));
        }
        if (results.Warnings.Any(kvp => kvp.Key == "badfilename"))
        {
            var correctWikiFileName = results.Warnings.First(kvp => kvp.Key == "badfilename").Value;
            _logger.LogWarning($"Received bad file name from wikipedia. old: {wikiFileName}, correct: File:{correctWikiFileName}");
            wikiFileName = "File:" + correctWikiFileName;
        }
        _logger.LogInformation($"Finished uploading image successfully. FileName: {fileName}, wikipage: {wikiFileName}");
        return wikiFileName;
    }

Code can be found here if you would like to see the entire file:
https://github.com/IsraelHikingMap/Site/blob/49ecea0f6e4a0c5e258c3124883ead422f0793b5/IsraelHiking.DataAccess/WikimediaCommonGateway.cs

Let me know if there's anything we can try out to solve this, as I think we are using the library as intended and this should work.

[HarelM]

Also if there's a curl I can try out from the server to see that login succeeds and there's no ip blocking or something, do let me know.

[HarelM]

@CXuesong any insights on this issue? Any recommendations?

[CXuesong]

Sorry for the delay. A typical cause of this is your session cookie is missing. For example, the CookieContainer somehow lost the cookie (which is unlikely), or the cookie you've received has wrong domain or expiry, which can happen if you are sending requests via some proxies. This eventually causes the action=login request handler rejects the login token retrieved in ‎WikiSite.LoginAsync‎.

WikiClientLibrary/WikiClientLibrary/Sites/WikiSite.cs

Lines 550 to 551 in d906e83

	if (_SiteInfo != null && _SiteInfo.Version >= new MediaWikiVersion(1, 27))
	token = await GetTokenAsync("login", true, cancellationToken);

In this case, MW API action=login handler will generate a new login token and reject the current request with Failed error (compatible with behavior before MW 1.27).

https://github.com/wikimedia/mediawiki/blob/d77143c4d5588b5d86898644f2052911dfad34ae/includes/Api/ApiLogin.php#L144

Our login process should be correct as long as the ‎TokensManager.GetTokenAsync call with forceRefetch := true in WikiSite.LoginAsync‎ always invokes the MW API to retrieve the latest login token. You can try to confirm this behavior on your side with either WCL logs or network request traces (recommended if possible).

As long as you can confirm a) you are sending correct cookies (the ones you received when retrieving the login token) and b) WCL is using the correct login token in action=login request, we may suspect there might be a bug with the MW API itself.

btw, there is a known issue with MW that logging out an account (via MW API) causes the same account to be logged out everywhere else: phab:T51890. Not sure whether this piece of information can be useful.

[HarelM]

Thanks for the info.
I have restarted my server and the login and upload worked for a day or so and then stopped working with a similar error.
I've changed the code to login every time just before uploading instead of keeping a reference to the instance.
My recent code can be found here:
https://github.com/IsraelHikingMap/Site/blob/8bd1e173a018b531f5bef2c21e00a44f195fccd0/IsraelHiking.DataAccess/WikimediaCommonGateway.cs

You can check this file in a previous version to see how it was before my recent change where a wikisite reference was saved between calls.

Let me know if this helps in any way...