Calibrated Values for Accelerometer Appear Incorrect

[theofficialgman]

When testing accelerometer values using the "button test" functionality I noticed that the displayed calibrated values for accelerometer appear to be incorrect (ie: not calibrated or calibrated incorrectly). I was setting a user calibration in HOS but for testing purposes now I have manually input a calibration value using the "edit calibration" functionality to the exact value as observed in the "Raw" column of the Acc Y value but the calculated "Cal" value still shows -0.25m/s2 when it should be showing 0m/s2

Gyro and Stick calculations appear to be correct.

[theofficialgman]

Maybe I am reading this wrong

jc_toolkit/jctool/jctool.cpp

Lines 1035 to 1050 in 9d0cc45

	input_report_sys = String::Format(L"Acc/meter (Raw/Cal):\r\n");
	//The controller sends the sensor data 3 times with a little bit different values. Skip them
	input_report_sys += String::Format(L"X: {0:X4} {1,7:F2} m/s\u00B2\r\n", buf_reply[13] | (buf_reply[14] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[13] | (buf_reply[14] << 8) & 0xFF00)) * acc_cal_coeff[0]);
	input_report_sys += String::Format(L"Y: {0:X4} {1,7:F2} m/s\u00B2\r\n", buf_reply[15] | (buf_reply[16] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[15] | (buf_reply[16] << 8) & 0xFF00)) * acc_cal_coeff[1]);
	input_report_sys += String::Format(L"Z: {0:X4} {1,7:F2} m/s\u00B2\r\n", buf_reply[17] | (buf_reply[18] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[17] | (buf_reply[18] << 8) & 0xFF00)) * acc_cal_coeff[2]);
	input_report_sys += String::Format(L"\r\nGyroscope (Raw/Cal):\r\n");
	input_report_sys += String::Format(L"X: {0:X4} {1,7:F2} rad/s\r\n", buf_reply[19] | (buf_reply[20] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[19] | (buf_reply[20] << 8) & 0xFF00) - uint16_to_int16(sensor_cal[1][0])) * gyro_cal_coeff[0]);
	input_report_sys += String::Format(L"Y: {0:X4} {1,7:F2} rad/s\r\n", buf_reply[21] | (buf_reply[22] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[21] | (buf_reply[22] << 8) & 0xFF00) - uint16_to_int16(sensor_cal[1][1])) * gyro_cal_coeff[1]);
	input_report_sys += String::Format(L"Z: {0:X4} {1,7:F2} rad/s\r\n", buf_reply[23] | (buf_reply[24] << 8) & 0xFF00,
	(float)(uint16_to_int16(buf_reply[23] | (buf_reply[24] << 8) & 0xFF00) - uint16_to_int16(sensor_cal[1][2])) * gyro_cal_coeff[2]);

but why was the gyro calibration corrected here but accelerometer was not 5a6ba9b ?

[theofficialgman]

hmm... checking hid-nintendo and joycon-serdev I see the comment which I think explains why the calibration offsets are not subtracted
https://gitlab.com/switchroot/kernel/l4t-kernel-4.9/-/blob/linux-dev/drivers/hid/hid-nintendo.c#L1144-1146
https://gitlab.com/switchroot/kernel/l4t-kernel-4.9/-/blob/linux-dev/drivers/input/joystick/joycon-serdev.c#L1410-1412
(because supposedly it makes the accuracy worse, @DanielOgorchock do you have thoughts on that since you authored that?)

What does HOS do?