From f3283c3b8a99089c3c6f674150831003a6bd2927 Mon Sep 17 00:00:00 2001
From: Ryan Sauge <71391932+rya-sge@users.noreply.github.com>
Date: Fri, 15 Aug 2025 13:17:59 +0200
Subject: [PATCH 01/23] Update aderyn report
---
doc/security/audits/tools/aderyn-report.md | 64 +++++++++++-----------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/doc/security/audits/tools/aderyn-report.md b/doc/security/audits/tools/aderyn-report.md
index 0d42edc..4f824c7 100644
--- a/doc/security/audits/tools/aderyn-report.md
+++ b/doc/security/audits/tools/aderyn-report.md
@@ -21,25 +21,25 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
| Key | Value |
| --- | --- |
| .sol Files | 11 |
-| Total nSLOC | 389 |
+| Total nSLOC | 466 |
## Files Details
| Filepath | nSLOC |
| --- | --- |
-| src/RuleEngine.sol | 49 |
-| src/RuleEngineBase.sol | 113 |
-| src/interfaces/IERC3643Compliance.sol | 13 |
+| src/RuleEngine.sol | 46 |
+| src/RuleEngineBase.sol | 129 |
+| src/interfaces/IERC3643Compliance.sol | 16 |
| src/interfaces/IRule.sol | 7 |
-| src/interfaces/IRulesManagementModule.sol | 16 |
-| src/modules/ERC3643ComplianceModule.sol | 49 |
-| src/modules/MetaTxModuleStandalone.sol | 6 |
-| src/modules/RulesManagementModule.sol | 111 |
-| src/modules/VersionModule.sol | 8 |
+| src/interfaces/IRulesManagementModule.sol | 12 |
+| src/modules/ERC2771ModuleStandalone.sol | 6 |
+| src/modules/ERC3643ComplianceModule.sol | 72 |
+| src/modules/RulesManagementModule.sol | 146 |
+| src/modules/VersionModule.sol | 14 |
| src/modules/library/RuleEngineInvariantStorage.sol | 4 |
-| src/modules/library/RulesManagementModuleInvariantStorage.sol | 13 |
-| **Total** | **389** |
+| src/modules/library/RulesManagementModuleInvariantStorage.sol | 14 |
+| **Total** | **466** |
## Issue Summary
@@ -62,52 +62,52 @@ Contracts have owners with privileged rights to perform admin tasks and need to
8 Found Instances
-- Found in src/modules/ERC3643ComplianceModule.sol [Line: 10](src/modules/ERC3643ComplianceModule.sol#L10)
+- Found in src/modules/ERC3643ComplianceModule.sol [Line: 11](src/modules/ERC3643ComplianceModule.sol#L11)
```solidity
abstract contract ERC3643ComplianceModule is IERC3643Compliance, AccessControl {
```
-- Found in src/modules/ERC3643ComplianceModule.sol [Line: 39](src/modules/ERC3643ComplianceModule.sol#L39)
+- Found in src/modules/ERC3643ComplianceModule.sol [Line: 44](src/modules/ERC3643ComplianceModule.sol#L44)
```solidity
- function bindToken(address token) public override virtual onlyRole(COMPLIANCE_MANAGER_ROLE) {
+ ) public virtual override onlyRole(COMPLIANCE_MANAGER_ROLE) {
```
-- Found in src/modules/ERC3643ComplianceModule.sol [Line: 44](src/modules/ERC3643ComplianceModule.sol#L44)
+- Found in src/modules/ERC3643ComplianceModule.sol [Line: 51](src/modules/ERC3643ComplianceModule.sol#L51)
```solidity
- function unbindToken(address token) public override virtual onlyRole(COMPLIANCE_MANAGER_ROLE) {
+ ) public virtual override onlyRole(COMPLIANCE_MANAGER_ROLE) {
```
-- Found in src/modules/RulesManagementModule.sol [Line: 16](src/modules/RulesManagementModule.sol#L16)
+- Found in src/modules/RulesManagementModule.sol [Line: 17](src/modules/RulesManagementModule.sol#L17)
```solidity
AccessControl,
```
-- Found in src/modules/RulesManagementModule.sol [Line: 38](src/modules/RulesManagementModule.sol#L38)
+- Found in src/modules/RulesManagementModule.sol [Line: 43](src/modules/RulesManagementModule.sol#L43)
```solidity
- ) public virtual override(IRulesManagementModule) onlyRole(RULE_ENGINE_OPERATOR_ROLE) {
+ onlyRole(RULES_MANAGEMENT_ROLE)
```
-- Found in src/modules/RulesManagementModule.sol [Line: 56](src/modules/RulesManagementModule.sol#L56)
+- Found in src/modules/RulesManagementModule.sol [Line: 69](src/modules/RulesManagementModule.sol#L69)
```solidity
- function clearRules() public virtual override(IRulesManagementModule) onlyRole(RULE_ENGINE_OPERATOR_ROLE) {
+ onlyRole(RULES_MANAGEMENT_ROLE)
```
-- Found in src/modules/RulesManagementModule.sol [Line: 65](src/modules/RulesManagementModule.sol#L65)
+- Found in src/modules/RulesManagementModule.sol [Line: 83](src/modules/RulesManagementModule.sol#L83)
```solidity
- ) public virtual override(IRulesManagementModule) onlyRole(RULE_ENGINE_OPERATOR_ROLE) {
+ onlyRole(RULES_MANAGEMENT_ROLE)
```
-- Found in src/modules/RulesManagementModule.sol [Line: 76](src/modules/RulesManagementModule.sol#L76)
+- Found in src/modules/RulesManagementModule.sol [Line: 102](src/modules/RulesManagementModule.sol#L102)
```solidity
- ) public virtual override(IRulesManagementModule) onlyRole(RULE_ENGINE_OPERATOR_ROLE) {
+ onlyRole(RULES_MANAGEMENT_ROLE)
```
1 Found Instances
-- Found in src/modules/RulesManagementModule.sol [Line: 45](src/modules/RulesManagementModule.sol#L45)
+- Found in src/modules/RulesManagementModule.sol [Line: 51](src/modules/RulesManagementModule.sol#L51)
```solidity
- for(uint256 i = 0; i < rules_.length; ++i){
+ for (uint256 i = 0; i < rules_.length; ++i) {
```