Corrections Needed in README and Type Hinting in Code

[cmj2002]

Thank you for your work on CEC. I'm very interested in your research because I'm currently doing similar work. I installed the environment according to your README and tried to run your code, and I found some issues in it.

First, The command to run the program in the README needs to be updated. The parameters passed in hydra should not include --. For example, python3 main/dmlab/train.py --method={METHOD} --task={TASK} --gpus={GPU} --data_path={DATA_PATH} should be changed to python3 main/dmlab/train.py method={METHOD} task={TASK} gpus={GPU} data_path={DATA_PATH}.

Secondly, it seems that you have used the wrong type hint, for example, you wrote list[float] instead of List[float], which will result in TypeError: 'type' object is not subscriptable. The same thing happens to Dict and Tuple.

I believe these issues might be bugs in the codebase. As such, I kindly request your assistance in addressing and rectifying these problems. After making these changes, please ensure to test the code thoroughly to prevent any further problems. Thank you.

[milong26]

I

Thank you for your work on CEC. I'm very interested in your research because I'm currently doing similar work. I installed the environment according to your README and tried to run your code, and I found some issues in it.

First, The command to run the program in the README needs to be updated. The parameters passed in hydra should not include --. For example, python3 main/dmlab/train.py --method={METHOD} --task={TASK} --gpus={GPU} --data_path={DATA_PATH} should be changed to python3 main/dmlab/train.py method={METHOD} task={TASK} gpus={GPU} data_path={DATA_PATH}.

Secondly, it seems that you have used the wrong type hint, for example, you wrote list[float] instead of List[float], which will result in TypeError: 'type' object is not subscriptable. The same thing happens to Dict and Tuple.

I believe these issues might be bugs in the codebase. As such, I kindly request your assistance in addressing and rectifying these problems. After making these changes, please ensure to test the code thoroughly to prevent any further problems. Thank you.

I followed you use command like python main/robomimic/train.py method=cec task=lift data_path="/mimicgen/datasets/core/" gpus=cpu, but it said

  @hydra.main(config_name="common", config_path="train_config")
Could not override 'method'.
To append to your config use +method=cec
Key 'method' is not in struct
    full_key: method
    object_type=dict

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Should I use '+' to override? And it told me again and agin cpu is not right,but i only have cpu now